From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67091 invoked by alias); 18 May 2016 02:34:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 67068 invoked by uid 89); 18 May 2016 02:34:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.2 spammy=HTo:U*dje, evans, Evans, U*dje X-HELO: layla.krisman.be Received: from layla.krisman.be (HELO layla.krisman.be) (176.31.208.35) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 18 May 2016 02:34:24 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (envelope-from ) id 1b2qsm-0002qC-MN; Wed, 18 May 2016 04:06:45 +0200 From: Gabriel Krisman Bertazi To: Doug Evans Cc: gdb-patches@sourceware.org, palves@redhat.com, sergiodj@redhat.com Subject: Re: [PATCH v5 1/5] Implemement support for groups of syscalls in the xml-syscall interface. References: <94eb2c124024cac63305330c515e@google.com> Date: Wed, 18 May 2016 02:34:00 -0000 In-Reply-To: <94eb2c124024cac63305330c515e@google.com> (Doug Evans's message of "Tue, 17 May 2016 16:34:48 +0000") Message-ID: <87lh38qel4.fsf@oberon.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg00288.txt.bz2 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Content-length: 995 Doug Evans writes: Hi Doug, thanks for your review. I'm fixing the things you pointed out and should submit a new version tomorrow. > > diff --git a/gdb/syscalls/gdb-syscalls.dtd > b/gdb/syscalls/gdb-syscalls.dtd > > index 3deda12..de47d4d 100644 > > --- a/gdb/syscalls/gdb-syscalls.dtd > > +++ b/gdb/syscalls/gdb-syscalls.dtd > > @@ -11,4 +11,5 @@ > > > > > name CDATA #REQUIRED > > - number CDATA #REQUIRED> > > + number CDATA #REQUIRED > > + groups CDATA #IMPLIED> > > I'm assuming "IMPLIED" is ok here, I don't actually know. According to the xml spec, there are two possible 'ID Attribute Default' values for an element: #REQUIRED and #IMPLIED. The spec says: "In an attribute declaration, #REQUIRED means that the attribute MUST always be provided, #IMPLIED that no default value is provided." Which makes me think that #IMPLIED is the correct value for this field. --=20 Gabriel Krisman Bertazi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" Content-length: 818 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXO9SnAAoJEO9pqxSS5VgPrqkP/1Ip2lLEVGdoq2FKm6gyFcXx 60acmBf3F7/9jGYcFH7EeMYCvtc7NGdwxqJAOTdtuBIIKVnMf2aSLkb1Ccgmamk0 SKTLdRGvkslv1FurRpYedhMC2A3GvnN2yrvS/iK01SnT/uNymGnYGUahSENyrRxp HvpWz/jbsRGBBBDO2BJPYuOeaKJ62+4sbQzzHm7OGR7NFJ+ZGwIlPOKImaBWWC5E //9fvA0PYfFkG1iCrLUQ0jgUPTYirLBkiiteonGTfwCV8SDMKqtzmW1w54IpO02v 5I24uXBbr0Q80OszJCHg4aK5RXGRFEPFAurtah+xKCjTVraNyaIRGJ2UwXl9sIOU GX/JG5CkW3ELIp5RQNQ9Itkf2/bl3c+cAGDW2WcoM24PdzVRQMvmByqtDWgHCkqF dP+jUmRyeqN1+OXKv/8p9brKhO59hPSWoai317TDieSIClA6YID/dSaEbUc0P2c4 fkbjhhRALsLdc+eA6i4XyyUweLELoag5LdDZiCtpkv6/R3m7Blg3STYPnOFVZqa6 s7O3D5fP99BAfO+N74Roaq603Pp/g0v0yskHTcJEpRgKFykLkFTzZpAQYRdH6O3M Pygjn/x3SJ0OX8iNDzOa6M28h62aCqy2oyZ3MTA5wgEv0Jak/vSOkigEEjzuXcHa ByRyJW0gGTwYxTRjOT57 =Z75Z -----END PGP SIGNATURE----- --=-=-=--