Re: [RFA v2 16/17] Convert dwarf_expr_context_funcs to methods

Tom Tromey
2016-10-18T14:55:30Z

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

>> All I saw was the comment about possibly reducing churn:
>> https://sourceware.org/ml/gdb-patches/2016-10/msg00208.html

Pedro> I'm sorry, I had written comments about the parenthesis
Pedro> thing and also about wondering whether these methods with
Pedro> internal_error could be pure virtual ('= 0;') instead, and if not,
Pedro> about adding a small comment mentioning it.

I think the internal_error thing can't be a pure virtual because there
are subclasses that do not implement this method. I could push the
internal error into the subclasses though.

Pedro> I sometimes write reviews of separate chunks in separate emails in
Pedro> then merge it all before sending. Guess I deleted that email
Pedro> by mistake.

It's no problem.

Tom