Re: [PATCH v6 3/4] Share fork_inferior et al with gdbserver

Sergio Durigan Junior
2017-06-07T21:01:43Z

On Wednesday, June 07 2017, Pedro Alves wrote:

> On 06/07/2017 11:15 AM, Pedro Alves wrote:
>> On 05/31/2017 04:43 AM, Sergio Durigan Junior wrote:
>>>
>>>>>>> index 4ea7913..8aa85db 100644
>>>>>>> --- a/gdb/gdbserver/configure.ac
>>>>>>> +++ b/gdb/gdbserver/configure.ac
>>>>>>> @@ -462,7 +462,9 @@ esac],
>>>>>>>
>>>>>>> if $want_ipa ; then
>>>>>>> if $have_ipa ; then
>>>>>>> - IPA_DEPFILES="$ipa_obj"
>>>>>>> + # Needed because safe_strerror's definition is host-dependent
>>>>>
>>>>> Why do we end up needing safe_strerror in the IPA in the first place?
>>> This is needed because I moved the definition of
>>> trace_start_error_with_name from the old gdb/fork-child.c to
>>> common/common-utils.c. This function which uses safe_strerror, and
>>> common/common-utils.c is compiled by IPA.
>>>
>>> An option would be to keep these trace_start_error.* functions in
>>> nat/fork-inferior.c, but I think it is more logical to keep them on
>>> common-utils.c.
>>
>> I'd rather not add them to the IPA. The least unnecessary code
>> is included in that library the better, because it is injected
>> into the target process. So keeping them in fork-inferior.c
>> sounds better.
>>
>
> I tried it against v7, and that works. The think to keep
> in mind is that these trace_start_error functions
> are only called from the fork child, so they're very much
> fork-inferior.c related.

They're actually being used by some -nat.c files on gdb/, and -low.c
files on gdbserver. But as I said, I'm OK with your suggestion.

--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible