Re: [PATCH v3 6/6] Implement proper "startup-with-shell" support on gdbserver

Pedro Alves
2017-03-13T15:12:49Z

On 03/07/2017 08:59 PM, Sergio Durigan Junior wrote:

>> Note, you'll need NEWS entries for the new remote protocol packets too.
>
> I've added a NEWS entry for QStartupWithShell under the "New remote
> packets" section. Do you want me to add another entry somewhere else?
>

Not offhand. I'll take a look at v4.

>> Can you explain the rationale for doing this here? What about:
>>
>> (gdb) target extended-remote ....
>> (gdb) set startup-with-shell off
>> (gdb) run
>>
>> ?
>
> Hm, I guess it just seemed like a good place to initialize the packet.
> But you're right, this won't work if the user sets the
> startup-with-shell parameter *after* connecting to the target. So I'll
> move this code to the extended_remote_create_inferior function, if
> that's alright.

Yes, that sounds like the right place. This is quite similar to
disabling address space randomization, and we do that in
extended_remote_create_inferior too.

Thanks,
Pedro Alves