Re: [PATCH v6 4/4] Implement proper "startup-with-shell" support on gdbserver

Pedro Alves
2017-05-05T19:21:50Z

On 05/04/2017 06:29 AM, Sergio Durigan Junior wrote:

> --- a/gdb/gdbserver/server.c
> +++ b/gdb/gdbserver/server.c
> @@ -877,6 +877,31 @@ handle_general_set (char *own_buf)
> return;
> }
>
> + if (startswith (own_buf, "QStartupWithShell:"))
> + {
> + char *value = own_buf + strlen ("QStartupWithShell:");

const.

> +set unique_file [standard_output_file "unique-file.unique-extension"]
> +set unique_file_dir [standard_output_file ""]
> +
> +run_on_host "touch $unique_file" "touch" "$unique_file"
> +

This may require some tweaking or disabling when tested against
a remote host. Not sure. Could you check whether the test runs
with testsuite/boards/local-remote-host-native.exp?

Otherwise this one LGTM.

Thanks,
Pedro Alves