Re: [PATCH v3 6/6] Implement proper "startup-with-shell" support on gdbserver

Eli Zaretskii
2017-02-08T17:34:22Z

> From: Sergio Durigan Junior <sergiodj@redhat.com>
> Cc: Pedro Alves <palves@redhat.com>, Luis Machado <lgustavo@codesourcery.com>, Sergio Durigan Junior <sergiodj@redhat.com>
> Date: Tue, 7 Feb 2017 22:22:57 -0500
>
> diff --git a/gdb/NEWS b/gdb/NEWS
> index 21e8cd3..f26e95e 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -3,6 +3,13 @@
>
> *** Changes since GDB 7.12
>
> +* GDBserver is now able to start inferiors using a shell. When using
> + "target extended-remote", the host GDB honors the value of "set
> + startup-with-shell" in order to inform GDBserver whether the remote
> + inferior should be started with a shell or not. When using "target
> + remote", it is possible to disable the startup with shell by using
> + the new parameter "--no-startup-with-shell" when starting GDBserver.
> +
> * Building GDB and GDBserver now requires a C++11 compiler.
>
> For example, GCC 4.8 or later.
> @@ -367,6 +374,9 @@ show max-value-size
>
> * New remote packets
>
> +QStartupWithShell
> + Indicates whether the inferior must be started with a shell or not.
> +
> exec stop reason
> Indicates that an exec system call was executed.

This part is OK.

> +If @var{value} is @var{0}, @command{gdbserver} will not use a shell to
> +start the inferior. If @var{value} is @var{1}, @command{gdbserver}

"0" and "1" should be in @samp, not @var, because they are literal
symbols.

> +@item E @var{nn}
> +An error occurred. The error number @var{nn} is give as hex digits.
^^^^
"given"

Documentation patch is OK with those minor issues fixed.

Thanks.