Re: [PATCH v7 4/4] Implement proper "startup-with-shell" support on gdbserver

Eli Zaretskii
2017-06-05T02:31:43Z

> From: Sergio Durigan Junior <sergiodj@redhat.com>
> Cc: Pedro Alves <palves@redhat.com>, Sergio Durigan Junior <sergiodj@redhat.com>
> Date: Sun, 4 Jun 2017 18:18:03 -0400
>
> A documentation patch is included, along with a new testcase for the
> feature.
>
> gdb/ChangeLog:
> yyyy-mm-dd Sergio Durigan Junior <sergiodj@redhat.com>
>
> * NEWS (Changes since GDB 8.0): Announce that GDBserver is now
> able to start inferiors using a shell.
> (New remote packets): Announce new packet "QStartupWithShell".
> * remote.c: Add PACKET_QStartupWithShell.
> (extended_remote_create_inferior): Handle new
> PACKET_QStartupWithShell.
> (remote_protocol_features) <QStartupWithShell>: New entry for
> PACKET_QStartupWithShell.
> (_initialize_remote): Call "add_packet_config_cmd" for
> QStartupShell.
>
> gdb/gdbserver/ChangeLog:
> yyyy-mm-dd Sergio Durigan Junior <sergiodj@redhat.com>
>
> * server.c (handle_general_set): Handle new packet
> "QStartupWithShell".
> (handle_query): Add "QStartupWithShell" to the list of supported
> packets.
> (gdbserver_usage): Add help text explaining the
> new "--startup-with-shell" and "--no-startup-with-shell" CLI
> options.
> (captured_main): Recognize and act upon the presence of the new
> CLI options.
>
> gdb/testsuite/ChangeLog:
> yyyy-mm-dd Sergio Durigan Junior <sergiodj@redhat.com>
>
> * gdb.base/startup-with-shell.c: New file.
> * gdb.base/startup-with-shell.exp: Likewise.
>
> gdb/doc/ChangeLog:
> yyyy-mm-dd Sergio Durigan Junior <sergiodj@redhat.com>
>
> * gdb.texinfo (Starting) <startup-with-shell>: Add @anchor.
> (Connecting) <Remote Packet>: Add "startup-with-shell"
> and "QStartupWithShell" to the table.
> (Remote Protocol) <QStartupWithShell>: New item, explaining the
> packet.

OK for the documentation parts.

Thanks.