From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30135 invoked by alias); 10 Apr 2017 23:21:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30112 invoked by uid 89); 10 Apr 2017 23:21:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: gproxy5.mail.unifiedlayer.com Received: from gproxy5-pub.mail.unifiedlayer.com (HELO gproxy5.mail.unifiedlayer.com) (67.222.38.55) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Apr 2017 23:21:35 +0000 Received: from CMOut01 (unknown [10.0.90.82]) by gproxy5.mail.unifiedlayer.com (Postfix) with ESMTP id 26E3D1430DB for ; Mon, 10 Apr 2017 17:19:31 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id 6nKT1v00d2f2jeq01nKWJh; Mon, 10 Apr 2017 17:19:31 -0600 X-Authority-Analysis: v=2.2 cv=cpDrqxwi c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=AzvcPWV-tVgA:10 a=kiSF8JxtU8vdWlhn8CsA:9 Received: from 75-166-65-226.hlrn.qwest.net ([75.166.65.226]:54362 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1cxial-0007lx-Ic; Mon, 10 Apr 2017 17:19:27 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 02/14] Introduce command_line_up References: <20170408201208.2672-1-tom@tromey.com> <20170408201208.2672-3-tom@tromey.com> Date: Mon, 10 Apr 2017 23:21:00 -0000 In-Reply-To: (Simon Marchi's message of "Sun, 09 Apr 2017 22:35:58 -0400") Message-ID: <87lgr7zw8x.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1cxial-0007lx-Ic X-Source-Sender: 75-166-65-226.hlrn.qwest.net (bapiya) [75.166.65.226]:54362 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2017-04/txt/msg00252.txt.bz2 >>>>> "Simon" == Simon Marchi writes: >> + /* Make sure not to free HEAD. */ >> + head.release (); >> + head.reset (next); Simon> I don't understand that bit, why the comment and the release? Just confusion on my part. Tom