From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19710 invoked by alias); 26 Apr 2017 19:42:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19693 invoked by uid 89); 26 Apr 2017 19:42:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Wednesday, wednesday X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Apr 2017 19:42:47 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 206D8C8F5E; Wed, 26 Apr 2017 19:42:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 206D8C8F5E Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=sergiodj@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 206D8C8F5E Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ED8D418693; Wed, 26 Apr 2017 19:42:47 +0000 (UTC) From: Sergio Durigan Junior To: Luis Machado Cc: GDB Patches Subject: Re: [PATCH v2] Make environ.exp run on all platforms (and create info-program.exp) References: <20170331172901.23402-1-sergiodj@redhat.com> <20170425204727.19158-1-sergiodj@redhat.com> Date: Wed, 26 Apr 2017 19:42:00 -0000 In-Reply-To: (Luis Machado's message of "Wed, 26 Apr 2017 13:43:53 -0500") Message-ID: <87lgqn7y6g.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00712.txt.bz2 On Wednesday, April 26 2017, Luis Machado wrote: > On 04/25/2017 03:47 PM, Sergio Durigan Junior wrote: >> Changes from v1: >> >> - Fixed regex of "show environment". >> >> - Make regexes of "info program" more flexible (for bare-metal >> targets). >> >> >> This has been on my TODO list for a while. There's a really old bug >> about this (PR testsuite/8595), and there was no reason for >> environ.exp to be specific for hppa* targets. So this patch removes >> this constraint, modernizes the testcase, and cleans up some things. >> Most of the tests remained, and some were rewritten (especially the >> one that checks if "show environment" works, which is something kind >> of hard to do). >> >> As a bonus, I'm adding a separated info-program.exp file containing >> all the tests related to "info program" that were present on >> environ.exp. >> >> Tested locally, everything still passes. >> >> gdb/testsuite/ChangeLog: >> 2017-04-25 Sergio Durigan Junior >> >> PR testsuite/8595 >> * gdb.base/environ.exp: Make test available in all architectures. >> Move bits related to "info program" testing to >> gdb.base/info-program.exp. Rewrite tests to use the two new >> procedures mentione below. >> (test_set_show_env_var) New procedure. >> (test_set_show_env_var_equal): Likewise. >> * gdb.base/info-program.exp: New file. >> --- >> gdb/testsuite/ChangeLog | 11 ++ >> gdb/testsuite/gdb.base/environ.exp | 302 ++++++-------------------------- >> gdb/testsuite/gdb.base/info-program.exp | 45 +++++ >> 3 files changed, 105 insertions(+), 253 deletions(-) >> create mode 100644 gdb/testsuite/gdb.base/info-program.exp > > I get full passes with gdb.base/environment.exp now, but > gdb.base/info-program.exp is still failing. > > FAIL: gdb.base/info-program.exp: info program after run to main > FAIL: gdb.base/info-program.exp: info program after next > FAIL: gdb.base/info-program.exp: info program after deleting all breakpoints > > By removing the initial \t from the patterns of these 3 tests, i get > full passes for gdb.base/info-program.exp as well. Sigh... Thanks for testing. OK, I'll remove the \t from the beginning. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/