From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107518 invoked by alias); 22 Sep 2017 17:29:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106817 invoked by uid 89); 22 Sep 2017 17:29:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.6 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS,TRACKER_ID autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Sep 2017 17:29:34 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 89B695F798 for ; Fri, 22 Sep 2017 17:29:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 89B695F798 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=sergiodj@redhat.com Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 605066E70F; Fri, 22 Sep 2017 17:29:33 +0000 (UTC) From: Sergio Durigan Junior To: Pedro Alves Cc: GDB Patches Subject: Re: [PATCH v3 1/5] Import "glob" and "getcwd" modules from gnulib References: <20170912042325.14927-1-sergiodj@redhat.com> <20170921225926.23132-1-sergiodj@redhat.com> <20170921225926.23132-2-sergiodj@redhat.com> <85ed7bac-f4d7-d348-01d1-acadcbbc56b8@redhat.com> Date: Fri, 22 Sep 2017 17:29:00 -0000 In-Reply-To: <85ed7bac-f4d7-d348-01d1-acadcbbc56b8@redhat.com> (Pedro Alves's message of "Fri, 22 Sep 2017 12:01:36 +0100") Message-ID: <87lgl64p6r.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00682.txt.bz2 On Friday, September 22 2017, Pedro Alves wrote: > On 09/21/2017 11:59 PM, Sergio Durigan Junior wrote: > >> * gnulib/import/m4/gnulib-cache.m4: Regenerate > > Missing period. Fixed. >> * ser-tcp.c: Undefine "close" before redefining it. > > diff --git a/gdb/ser-tcp.c b/gdb/ser-tcp.c > index f35991c..c8be37b 100644 > --- a/gdb/ser-tcp.c > +++ b/gdb/ser-tcp.c > @@ -42,6 +42,7 @@ >> #ifndef ETIMEDOUT >> #define ETIMEDOUT WSAETIMEDOUT >> #endif >> +#undef close >> #define close(fd) closesocket (fd) >> #define ioctl ioctlsocket >> #else > > Please add a comment. Something like: > > /* Gnulib defines close too, but gnulib's replacement > doesn't call closesocket unless we import the > socketlib module. */ Added. > Otherwise OK. Pushed. 6ec2e0f5bddc69d55e09fe56792edf7a109ff8ae Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/