From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24635 invoked by alias); 26 Feb 2018 19:16:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24329 invoked by uid 89); 26 Feb 2018 19:15:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.113) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Feb 2018 19:15:48 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 59A55B4BC6 for ; Mon, 26 Feb 2018 13:15:38 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id qOFOemko4uMnyqOFOeQ06W; Mon, 26 Feb 2018 13:15:38 -0600 Received: from 174-29-60-18.hlrn.qwest.net ([174.29.60.18]:40422 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1eqOFN-002o1F-Sg; Mon, 26 Feb 2018 13:15:37 -0600 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH] Add test for load command References: <20180225173703.6675-1-tom@tromey.com> <20180225204354.6307-1-simon.marchi@polymtl.ca> Date: Mon, 26 Feb 2018 19:16:00 -0000 In-Reply-To: <20180225204354.6307-1-simon.marchi@polymtl.ca> (Simon Marchi's message of "Sun, 25 Feb 2018 15:43:54 -0500") Message-ID: <87lgffpnon.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1eqOFN-002o1F-Sg X-Source-Sender: 174-29-60-18.hlrn.qwest.net (pokyo) [174.29.60.18]:40422 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-02/txt/msg00396.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> [[Hi Tom, Simon> What do you think of adding this test to check this code path?]] Simon> There doesn't seem to by any test for the load command. I suggest to Simon> add this test, so that we can have a minimum of confidence we don't Simon> break it completely while refactoring the code that implements it. This seems like a good idea to me. I read the test and it seems reasonable. Thank you very much for doing this. Tom