From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32251 invoked by alias); 9 May 2018 20:31:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32232 invoked by uid 89); 9 May 2018 20:31:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=guidelines, Save, 6117, Hx-languages-length:1000 X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.146.82) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 May 2018 20:31:12 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 09A54743C40 for ; Wed, 9 May 2018 15:31:11 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id GVjzfTfCHlAdrGVjzf11w0; Wed, 09 May 2018 15:31:11 -0500 X-Authority-Reason: nr=8 Received: from 97-122-176-117.hlrn.qwest.net ([97.122.176.117]:34302 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1fGVjy-001H9n-Q7; Wed, 09 May 2018 15:31:10 -0500 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 03/12] Update core-related help strings References: <20180430143731.30007-1-tom@tromey.com> <20180430143731.30007-4-tom@tromey.com> <3cfb1618-6bf4-e92b-b841-b80bba1e553e@redhat.com> Date: Wed, 09 May 2018 20:31:00 -0000 In-Reply-To: <3cfb1618-6bf4-e92b-b841-b80bba1e553e@redhat.com> (Pedro Alves's message of "Fri, 4 May 2018 19:11:32 +0100") Message-ID: <87lgcs4lma.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fGVjy-001H9n-Q7 X-Source-Sender: 97-122-176-117.hlrn.qwest.net (bapiya) [97.122.176.117]:34302 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-05/txt/msg00214.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> On 04/30/2018 03:37 PM, Tom Tromey wrote: >> diff --git a/gdb/gcore.c b/gdb/gcore.c >> index 5ff4e6dc77..c53810049c 100644 >> --- a/gdb/gcore.c >> +++ b/gdb/gcore.c >> @@ -611,7 +611,8 @@ _initialize_gcore (void) >> { >> add_com ("generate-core-file", class_files, gcore_command, _("\ >> Save a core file with the current state of the debugged process.\n\ >> -Argument is optional filename. Default filename is 'core.'.")); >> +Usage: generate-core-file [FILENAME]\n\ >> +Argument is optional filename. Default filename is 'core.PROCESS_ID'.")); Pedro> Do the guidelines say anything about this? I mean, PROCESS_ID is not Pedro> user input, so I'm wondering whether it should be all caps, or whether Pedro> it was better as it was. Pedro> Otherwise looks fine. The docs don't say much, but since the PID is a meta-syntactic variable, I think this is the way to go. Tom