From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15238 invoked by alias); 1 Jun 2018 21:03:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15204 invoked by uid 89); 1 Jun 2018 21:03:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.51.122) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 01 Jun 2018 21:03:37 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 1F72A5D78 for ; Fri, 1 Jun 2018 16:03:36 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id OrCyfHuG379N3OrCyfmoqm; Fri, 01 Jun 2018 16:03:36 -0500 X-Authority-Reason: nr=8 Received: from 75-166-42-107.hlrn.qwest.net ([75.166.42.107]:43894 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fOrCx-001guq-Sa; Fri, 01 Jun 2018 16:03:35 -0500 From: Tom Tromey To: Keith Seitz Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 3/6] Make PSYMBOL_VALUE_ADDRESS take objfile argument References: <20180503223621.22544-1-tom@tromey.com> <20180503223621.22544-4-tom@tromey.com> <1a874bc2-1a4d-3dd5-4718-10b93d5d2868@redhat.com> Date: Fri, 01 Jun 2018 21:03:00 -0000 In-Reply-To: <1a874bc2-1a4d-3dd5-4718-10b93d5d2868@redhat.com> (Keith Seitz's message of "Fri, 1 Jun 2018 13:06:32 -0700") Message-ID: <87lgbyb4ns.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fOrCx-001guq-Sa X-Source-Sender: 75-166-42-107.hlrn.qwest.net (pokyo) [75.166.42.107]:43894 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-06/txt/msg00035.txt.bz2 >>>>> "Keith" == Keith Seitz writes: Keith> Just a word of warning: ANOFFSET will assert if PSYMBOL_SECTION is Keith> -1. [Setting that field isn't added until the last patch.] As a Keith> result, I am seeing a lot of temporary regressions. I build with -O0, Keith> so maybe these won't show up during a buildbot test run? Maybe they would, and anyway it seems like bad form to rely on this being optimized out. Since the goal here is just to do some syntax checking maybe there is another form that could be used, like (0 ? 0 : (ANOFFSET ((objfile)->section_offsets, ((symbol)->pginfo.section)))) Not sure if that will trigger warnings, but I can find out. If that doesn't work one idea would be to just drop it from the patch, since it has done its job already. Tom