From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72876 invoked by alias); 15 Jul 2018 18:43:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72866 invoked by uid 89); 15 Jul 2018 18:43:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Cool, 2018-05-23, 20180523, Hx-languages-length:1223 X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.146.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 15 Jul 2018 18:43:30 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 7378449ABB for ; Sun, 15 Jul 2018 13:43:29 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id elzVfBmUbRPojelzVfkF7f; Sun, 15 Jul 2018 13:43:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+VnXanGrAJylynzfXaTDFyOLE1Zq1UHGZrcUCsGz1lo=; b=iOiEMWUsZ4WJtc77VR+Z6Q1cA6 +IEkyKJc+Y00c+R6fVpP5H3j3ZmoJE/DzYoGPrseNWZ6RSRSXcl46YWJdASByE5837VfdNrPh8MZM Er5R59s9loCymNh0VxdDfnrYl; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:36208 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1felzV-000j6i-74; Sun, 15 Jul 2018 13:43:29 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 38/42] Introduce legacy-buildsym.h References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-39-tom@tromey.com> <89126236-88df-d625-63f9-6cfac82b44a7@simark.ca> Date: Sun, 15 Jul 2018 18:43:00 -0000 In-Reply-To: <89126236-88df-d625-63f9-6cfac82b44a7@simark.ca> (Simon Marchi's message of "Tue, 10 Jul 2018 00:22:12 -0400") Message-ID: <87lgac8hm7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00469.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> On 2018-05-23 12:58 AM, Tom Tromey wrote: >> This introduces a new header, legacy-buildsym.h, and changes all the >> symbol readers to use it. The idea is to put the function-based >> interface, that relies on the buildsym_compunit global, into a >> separate header. Then when a symbol reader is updated to use the new >> interface, it can simply not include legacy-buildsym.h, so it's easy >> to be sure that the new API is used everywhere. Simon> Cool, good idea. I have two suggestions: Simon> - Name it buildsym-legacy.h, so that it will be ordered right next to Simon> buildsym.h in alphabetical lists. Simon> - I would also create buildsym-legacy.c and move all the corresponding Simon> definitions there, including the buildsym_compunit global variable. Simon> I haven't actually tried it, maybe it's not possible and you have Simon> already tried it though. I did these. I think I've made it through all the review comments. I'm running the result through the buildbot again & then I will re-submit it. I think due to the number of rebases and edits required it will need another round of review. Tom