From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97849 invoked by alias); 16 Jul 2018 15:58:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 97836 invoked by uid 89); 16 Jul 2018 15:58:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.146.80) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Jul 2018 15:58:00 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 1180B20345D for ; Mon, 16 Jul 2018 10:57:59 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id f5stfscN9BcCXf5stfYe1C; Mon, 16 Jul 2018 10:57:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xWqfly3i4266njVh4fEFLm6mTFfBGUzT0z/BaykxerM=; b=ckryQO2VcQribiRauhrEUUR2/h rHnIt61abI2B58iF5fxeqO3/qcXOUnMB/tlCGeYQWWcKVaz89zIFlUWdbQhMcQ/eLCxgYrmmvZP4P 4IuATNLOj8eFPeCSyRlCL6uzB; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:38296 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1ff5ss-000Hbw-Pi; Mon, 16 Jul 2018 10:57:58 -0500 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , Simon Marchi , gdb-patches@sourceware.org Subject: Re: [RFA 04/13] Call some functions in guile/ for effect References: <20180712205208.32646-1-tom@tromey.com> <20180712205208.32646-5-tom@tromey.com> <490c9b62-f209-e5b6-e47d-615d64a39451@simark.ca> <87muuu9ekc.fsf@tromey.com> Date: Mon, 16 Jul 2018 15:58:00 -0000 In-Reply-To: (Pedro Alves's message of "Mon, 16 Jul 2018 14:54:32 +0100") Message-ID: <87lgab6um2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00487.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> ... we can't call value_bytes_available on a lazy value (because that function must Pedro> be usable with values in the values history, that's why it works with a const value *), Pedro> so the desired side effect here is fetching a lazy value. So I think we Pedro> should replace that with: Pedro> if (value_lazy (val)) Pedro> value_fetch_lazy (val); Pedro> The Python seems to have the same issue, so I think it'd be Pedro> a little better to handle both this hunk and the equivalent bit Pedro> in Python in the same patch, and in its own patch. I did this Tom