From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6507 invoked by alias); 6 Aug 2018 19:07:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6463 invoked by uid 89); 6 Aug 2018 19:07:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (50.116.126.2) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 Aug 2018 19:06:58 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 507BC400EDEE7 for ; Mon, 6 Aug 2018 13:09:42 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id mkpnfvVlj79N3mkq3fED1V; Mon, 06 Aug 2018 14:06:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qsioJGmN3X70KVt19MBx6tjUwQpk1tpfc90UNp4BtZo=; b=XA/70LeL6DCvIrOAyPU3E0LT+d 8oAxq6L7YUYmsuF3rUXY2ua2dozelKL+l7g0I/JI6/lK8j1H+sVfbF5fKJ60AeGpgx0nzk17my3qx sis8QKW9TZOH1gkaD6e6VK2et; Received: from [75.166.85.72] (port=39578 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fmkpn-0027vW-8L; Mon, 06 Aug 2018 14:06:27 -0500 From: Tom Tromey To: Richard Bunt Cc: gdb-patches@sourceware.org, nd@arm.com Subject: Re: [PATCH] Logical short circuiting with Fortran argument lists References: <20f669fe-9f31-fd39-9c3e-f2e1835576c6@arm.com> Date: Mon, 06 Aug 2018 19:07:00 -0000 In-Reply-To: <20f669fe-9f31-fd39-9c3e-f2e1835576c6@arm.com> (Richard Bunt's message of "Fri, 3 Aug 2018 10:32:44 +0100") Message-ID: <87lg9jz55b.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00103.txt.bz2 >>>>> "Richard" == Richard Bunt writes: Richard> Investigation revealed that EVAL_SKIP was not being handled correctly Richard> for all types serviced by the OP_F77_UNDETERMINED_ARGLIST case in Richard> evaluate_subexp_standard. While skipping an undetermined argument Richard> list the type is resolved to be an integer (as this is what Richard> evaluate_subexp returns when skipping) and so it was not possible to Richard> delegate to the appropriate case (e.g. array, function call). While I agree with Simon that this patch is fine, I think the intended design of eval.c is that skipped expressions should still try to return a value of the correct type when possible. The reason for this is that the type is still sometimes needed, for example to compute the correct type of a ?: ternary operator, which in turn could be used for overload resolution. Richard> While this patch allows a wider range of expressions to be evaluated, it Richard> should be noted that this patch does not allow the skipping of arrays Richard> which use Fortran array slicing, due to the inability of the debugger Richard> to skip OP_RANGE. This sounds like a bug to me. Tom