From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48685 invoked by alias); 28 Aug 2018 15:54:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48670 invoked by uid 89); 28 Aug 2018 15:54:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.47.79) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Aug 2018 15:54:19 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway22.websitewelcome.com (Postfix) with ESMTP id BB2027262 for ; Tue, 28 Aug 2018 10:54:17 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ugJVfpyqPBcCXugJkfKPN6; Tue, 28 Aug 2018 10:54:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZDii8WaWWxi1huwgJqq4i2q8MO+NZLPBaq6iNnn3Fr0=; b=cr4LyfEz2N3o4ByXh9ABFm29/p bsiKiNmMImLv6RQi5qi5SrVU8KfTwpGxwfEvXMCpZSoS0v1f0L26cyf5mU0kmT2k6YIcq9HIcwtAZ 4tagHTaGTOIjyCScw5qpcqAWl; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:47060 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fugJV-001XLE-HA; Tue, 28 Aug 2018 10:53:53 -0500 From: Tom Tromey To: Andrew Burgess Cc: Philippe Waroquiers , gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] gdb: Allow parenthesis to group arguments to user-defined commands References: <1535225533.1438.5.camel@skynet.be> <1535230403.1438.10.camel@skynet.be> <20180825224310.GA32506@embecosm.com> Date: Tue, 28 Aug 2018 15:54:00 -0000 In-Reply-To: <20180825224310.GA32506@embecosm.com> (Andrew Burgess's message of "Sat, 25 Aug 2018 23:43:10 +0100") Message-ID: <87lg8q7ai7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00687.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: Andrew> So, my suggestion deliberately avoids using quotes or backslashes as Andrew> these are bogged down in the existing code. And using (...) is fairly Andrew> intuitive given GDBs C like expression handling, personally I'd rather Andrew> write: Andrew> my_command ({unsigned long long} &global_var) Andrew> than: Andrew> my_command {unsigned\ long\ long}\ &global_var FWIW I tend to agree with your logic here. User-defined argument parsing is broken (and I think there's at least one bug in bugzilla about this), but at the same time, making breaking changes seems unfriendly. Your approach doesn't seem to be breaking anything that is likely to be actually used. Tom