From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83722 invoked by alias); 23 Sep 2018 21:25:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 78020 invoked by uid 89); 23 Sep 2018 21:25:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_RP_RNBL,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1082 X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.140) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 23 Sep 2018 21:25:12 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 6668CA7474 for ; Sun, 23 Sep 2018 16:25:01 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 4BsDgi1KgkBj64BsDgqxuQ; Sun, 23 Sep 2018 16:25:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=0uCKaegmdo5ymTfjv+9F2QdzL0uvCiw0ZoSIpfJFqdI=; b=lmQEXEz0Xgq4rAR+G810SoEsXe wPbLfGEHcc9fa1lC5k1tTZ4mYYNZgB0bMnB3t5OnUh9j5lLh3exTC+WmfKqLy3I9q6wt6eTj2gdls NFUxhpcfVqC0ERNavpUBtMtW+; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:41392 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g4BsD-001UMY-2x; Sun, 23 Sep 2018 16:25:01 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Subject: Re: [RFA 13/15] Add psymtab_storage::allocate_dependencies References: <20180510222357.27332-1-tom@tromey.com> <20180510222357.27332-14-tom@tromey.com> Date: Sun, 23 Sep 2018 21:25:00 -0000 In-Reply-To: (Simon Marchi's message of "Wed, 18 Jul 2018 10:31:46 -0400") Message-ID: <87lg7rlxec.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00783.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> On 2018-05-10 06:23 PM, Tom Tromey wrote: >> diff --git a/gdb/dbxread.c b/gdb/dbxread.c >> index c3741fda8a..e1aed48ff7 100644 >> --- a/gdb/dbxread.c >> +++ b/gdb/dbxread.c >> @@ -2092,13 +2092,8 @@ dbx_end_psymtab (struct objfile *objfile, struct partial_symtab *pst, >> pst-> number_of_dependencies = number_dependencies; >> if (number_dependencies) >> - { >> - pst->dependencies = XOBNEWVEC (&objfile->objfile_obstack, >> - struct partial_symtab *, >> - number_dependencies); >> - memcpy (pst->dependencies, dependency_list, >> - number_dependencies * sizeof (struct partial_symtab *)); >> - } >> + pst->dependencies >> + = objfile->partial_symtabs->allocate_dependencies (number_dependencies); Simon> There is a memcpy that disappears here, probably not intended? Same in xcoffread. Thanks, I fixed this. There was also a spot in dbxread.c where there should have been another change to call allocate_dependencies; I fixed this as well. Tom