Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: Tom Tromey <tom@tromey.com>,  gdb-patches@sourceware.org
Subject: Re: [FYI] Handle TYPE_CODE_PTR when printing Rust types
Date: Mon, 19 Nov 2018 18:23:00 -0000	[thread overview]
Message-ID: <87lg5porj5.fsf@tromey.com> (raw)
In-Reply-To: <87pnv44nij.fsf@redhat.com> (Sergio Durigan Junior's message of	"Fri, 16 Nov 2018 18:21:24 -0500")

>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:

>> +	    /* We currently can distinguish between pointers and
>> +	       references.  */

Sergio> I understand you'll send a new version of the patch soon, but this
Sergio> caught my attention.  I think you meant to say "... can't
Sergio> distinguish...", right?  At least that's what I understand from the code
Sergio> below.

Thanks, Keith noticed this too :)
I've fixed it for the next version.

Tom


      reply	other threads:[~2018-11-19 18:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-16 22:33 Tom Tromey
2018-11-16 22:35 ` Tom Tromey
2018-11-16 23:21 ` Sergio Durigan Junior
2018-11-19 18:23   ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lg5porj5.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sergiodj@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox