From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68439 invoked by alias); 28 Feb 2019 20:17:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68391 invoked by uid 89); 28 Feb 2019 20:17:05 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KAM_NUMSUBJECT,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Feb 2019 20:17:04 +0000 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CF6F030A2201; Thu, 28 Feb 2019 20:17:02 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id A39061973C; Thu, 28 Feb 2019 20:17:02 +0000 (UTC) From: Sergio Durigan Junior To: Eli Zaretskii Cc: brobecker@adacore.com, gdb-patches@sourceware.org Subject: Re: MinGW build of GDB 8.2.90 References: <20190227055112.4A5E782D7B@joel.gnat.com> <837edjkbp4.fsf@gnu.org> <87pnrbivz4.fsf@redhat.com> <8336o7k89n.fsf@gnu.org> Date: Thu, 28 Feb 2019 20:17:00 -0000 In-Reply-To: <8336o7k89n.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 28 Feb 2019 21:44:36 +0200") Message-ID: <87lg1zis75.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00576.txt.bz2 On Thursday, February 28 2019, Eli Zaretskii wrote: >> From: Sergio Durigan Junior >> Cc: Joel Brobecker , gdb-patches@sourceware.org >> Date: Thu, 28 Feb 2019 13:55:27 -0500 >> >> However, and more importantly, I remember testing the whole patch by >> compiling it using a mingw32 compiler on Fedora, and it was working >> correctly. In fact, we even have a mingw32 builder on our BuildBot >> (running on Fedora), and it is still compiling GDB without problems: >> >> https://gdb-build.sergiodj.net/builders/Fedora-x86_64-w64-mingw32 >> >> So apparently this error is only triggered when you use mingw on >> Windows...? I don't know. > > No, the problem is that there are two flavors of MinGW, and I used the > other one. Understood. >> As I said, I don't use Windows and don't understand the system, but if >> these changes fix the problem for you, I'd say they're justified and >> should be pushed (even though I don't understand the "if >> _WIN32_WINNT..." part). > > For the record, the _WIN32_WINNT part is because mingw.org's MinGW by > default defines _WIN32_WINNT to target older versions of Windows, > which don't support getaddrinfo, and the Windows API headers then mask > the prototypes of those functions. Thanks for the explanation. >> > Note that one other side effect of the IPv6 support additions is that >> > on MS-Windows GDB will no longer run on versions older than XP, I >> > guess this is something that should be mentioned in NEWS? >> >> I confess I did not know that. If that's the case, then we should >> indeed notify the users via the NEWS file, IMO. > > OK, will do. > >> > CXX xml-syscall.o >> > xml-syscall.c: In function 'bool xml_list_syscalls_by_group(gdbarch*, const char*, std::vector*)': >> > xml-syscall.c:475:14: warning: types may not be defined in a for-range-declaration >> > for (const struct syscall_desc *sysdesc : groupdesc->syscalls) >> > ^~~~~~ >> > >> > I solved the latter by removing "struct" from the declaration. This >> > is with GCC 6.3.0; is that a GCC bug? is removing "struct" the right >> > solution? >> >> Yeah, this is the right thing to do. I remember having to do this a few >> times, and seeing other patches doing the same. > > OK, will do that as well. > > Thanks for the feedback. Thank you for taking care of it. Just as a reminder, these changes need to be pushed to origin/master as well. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/