From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59458 invoked by alias); 5 Mar 2019 19:32:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 59446 invoked by uid 89); 5 Mar 2019 19:32:44 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:614 X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.51.61) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Mar 2019 19:32:42 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 9EBAB42571 for ; Tue, 5 Mar 2019 13:32:41 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 1FnthiNmj2PzO1Fnth7Jxb; Tue, 05 Mar 2019 13:32:41 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=2svjI5uAzq5MB4VHdWACQYLWTHGxgoBwBPXpeHxGX9U=; b=geEYRhD9hK+jYn/6hmxRd6pZsK Eg8NVd36Cy/tscuNjntNJevrEmjInju5YGGlBoFagjZMAXmXKPouzUiKKv2f6P0i1qsZ/Wco3ku1v N3MGrAcSg+yvp7hHbbVH4N9By; Received: from 75-166-85-218.hlrn.qwest.net ([75.166.85.218]:54178 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1h1Fnt-000G6p-8j; Tue, 05 Mar 2019 13:32:41 -0600 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/4] Make "checkpoint" not rely on inferior_ptid References: <20190305184340.26768-1-palves@redhat.com> <20190305184340.26768-2-palves@redhat.com> Date: Tue, 05 Mar 2019 19:32:00 -0000 In-Reply-To: <20190305184340.26768-2-palves@redhat.com> (Pedro Alves's message of "Tue, 5 Mar 2019 18:43:37 +0000") Message-ID: <87lg1truav.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-03/txt/msg00068.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> In the Pedro> multi-target branch, I'm forcing inferior_ptid to null_ptid early in Pedro> infrun event handling to make sure we inadvertently rely on the Pedro> current thread/target when we shouldn't, and that caught some bad Pedro> or unnecessary assumptions throughout. This read a bit strangely to me. Maybe instead write "to make sure we don't inadvertently rely on the current thread/target,..."? The patch itself seemed fine to me. Big +1 to reducing the impact of globals. Tom