From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112790 invoked by alias); 27 Mar 2019 21:36:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112731 invoked by uid 89); 27 Mar 2019 21:36:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.143.40) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Mar 2019 21:36:55 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 3B4522C360 for ; Wed, 27 Mar 2019 16:36:54 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 9GEAhUC6C90on9GEAhj7vn; Wed, 27 Mar 2019 16:36:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3wXFZnAF/Xny0zB/Md1Sleofk+ayhPLMJUQpjO3hGp4=; b=fLhJEzb54OuNjhcP3SWlhsqXhp 5hdlnybSmUWKXwbYlLP35de5G5Wkjmg46WEaHuFfVqjEtrKfBkVPEyBxqX3C4Rif/hPcMNdzPSMa6 vHiKSCY7V1y7sZ5gTe3BCxB2F; Received: from 174-29-37-56.hlrn.qwest.net ([174.29.37.56]:43002 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1h9GE9-000b6B-UQ; Wed, 27 Mar 2019 16:36:54 -0500 From: Tom Tromey To: LRN Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Apply substitute-path to relative filenames as well References: <5a785bba-7432-f6e0-1089-5d2bdd3450a3@gmail.com> <871s3lq8fy.fsf@tromey.com> <5415b22f-c46c-8dbf-4481-98be267e25bb@gmail.com> Date: Wed, 27 Mar 2019 21:36:00 -0000 In-Reply-To: <5415b22f-c46c-8dbf-4481-98be267e25bb@gmail.com> (LRN's message of "Wed, 13 Mar 2019 15:47:24 +0300") Message-ID: <87lg10knii.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-03/txt/msg00672.txt.bz2 >>>>> "LRN" == LRN writes: >> Thank you for the patch. LRN> Hey, it's been a week. Do i need to do something to move this along? (Please, LRN> don't say "test case" :( ) Is it possible to write one? I didn't think about it in detail. The norm is that a patch should come with a test case. Exceptions are for refactoring patches, where the intent is to preserve semantics; and for the relatively rare cases where a test is very difficult or impossible to write. I see there are already tests in gdb.base/subst.exp. Perhaps it could be extended? Also the review had a little nit that could be addressed. thanks, Tom