From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-156152-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 93638 invoked by alias); 16 May 2019 18:08:43 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 93627 invoked by uid 89); 16 May 2019 18:08:43 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-14.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: rock.gnat.com
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 May 2019 18:08:42 +0000
Received: from localhost (localhost.localdomain [127.0.0.1])	by filtered-rock.gnat.com (Postfix) with ESMTP id 7020E117C49;	Thu, 16 May 2019 14:08:40 -0400 (EDT)
Received: from rock.gnat.com ([127.0.0.1])	by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024)	with LMTP id Br9rqcxjU4MF; Thu, 16 May 2019 14:08:40 -0400 (EDT)
Received: from murgatroyd (71-218-69-43.hlrn.qwest.net [71.218.69.43])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by rock.gnat.com (Postfix) with ESMTPSA id ED7E911715C;	Thu, 16 May 2019 14:08:39 -0400 (EDT)
From: Tom Tromey <tromey@adacore.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: Tom Tromey <tromey@adacore.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH] Add "set print finish"
References: <20190516163244.20180-1-tromey@adacore.com>	<20190516175246.GR2568@embecosm.com>
Date: Thu, 16 May 2019 18:08:00 -0000
In-Reply-To: <20190516175246.GR2568@embecosm.com> (Andrew Burgess's message of	"Thu, 16 May 2019 18:52:46 +0100")
Message-ID: <87lfz6w9ug.fsf@tromey.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2019-05/txt/msg00384.txt.bz2

>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

>> +  add_setshow_boolean_cmd ("finish", class_support,
>> +			   &user_print_options.finish_print, _("\
>> +Set whether `finish' prints the return value."), _("\
>> +Show whether `finish' prints the return value."), NULL,
>> +			   NULL,
>> +			   show_print_finish,
>> +			   &setprintlist, &showprintlist);


>> +  /* Whether "finish" should print the value.  */
>> +  int finish_print;
>> };

Andrew> Should new flags not be bool ?

Ordinarily, but in this case the address of one of these is passed to
add_setshow_boolean_cmd, which still takes an "int *" -- see the code I
quoted above.

Tom