From: Tom Tromey <tom@tromey.com>
To: Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
Cc: gdb-patches@sourceware.org, kevinb@redhat.com
Subject: Re: [PATCH] Fix access to uninitialized variable in fill_in_stop_func
Date: Thu, 08 Aug 2019 17:14:00 -0000 [thread overview]
Message-ID: <87lfw360lt.fsf@tromey.com> (raw)
In-Reply-To: <20190808135443.10894-1-pedromfc@linux.ibm.com> (Pedro Franco de Carvalho's message of "Thu, 8 Aug 2019 10:54:43 -0300")
>>>>> "Pedro" == Pedro Franco de Carvalho <pedromfc@linux.ibm.com> writes:
Pedro> This patch changes fill_in_stop_func to check the return value of
Pedro> find_pc_partial_function before accessing the block pointer that is only
Pedro> written by find_pc_partial_function if it returns a success status.
Pedro> gdb/ChangeLog:
Pedro> YYYY-MM-DD Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
Pedro> * infrun.c (fill_in_stop_func): Use return value of
Pedro> find_pc_partial_function, remove comment.
The comment for find_pc_partial_function says:
nullptr is used as a return value for *BLOCK if no block is found.
... which implies to me that the function was intended to set *BLOCK
unconditionally. Perhaps Kevin could say, as I think he added the block
parameter.
Tom
next prev parent reply other threads:[~2019-08-08 17:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 13:54 Pedro Franco de Carvalho
2019-08-08 17:14 ` Tom Tromey [this message]
2019-08-08 17:42 ` Kevin Buettner
2019-08-09 19:13 ` Pedro Franco de Carvalho
2019-08-09 19:17 ` Kevin Buettner
2019-08-09 19:52 ` Pedro Franco de Carvalho
2019-08-09 20:42 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfw360lt.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=pedromfc@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox