From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25399 invoked by alias); 25 Sep 2019 22:08:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25391 invoked by uid 89); 25 Sep 2019 22:08:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=andrew.burgess@embecosm.com, U*andrew.burgess, andrewburgessembecosmcom X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.122) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Sep 2019 22:08:30 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway32.websitewelcome.com (Postfix) with ESMTP id A4BEC2AC15 for ; Wed, 25 Sep 2019 17:08:28 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id DFSWiYC28W4frDFSWiFs7E; Wed, 25 Sep 2019 17:08:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=X+ynxYTIt/ThX4/p+mMTRZAfeGbJEIJAKmLaSoPRZTM=; b=bBavXgVhGSd/RPu2OMYvPMDfCO /F3tAW465VZQAZEF0G+APbvfggZ4eC6pvFL0ini7W99ck47kMYT5m3HHnRWGdBrXXw/qnJwpI85Hn DrHKEmlWJV90g46fb5JeuPa/F; Received: from 71-218-73-27.hlrn.qwest.net ([71.218.73.27]:40988 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iDFSW-000b8l-Ba; Wed, 25 Sep 2019 17:08:28 -0500 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches , Simon Marchi , Tom Tromey Subject: Re: [PATCHv2 3/3] gdb: Remove a use of VEC from dwarf2read.{c,h} References: <0dcd5cbc1c863f32bbc513db657e3c2aec2dadb7.1569425799.git.andrew.burgess@embecosm.com> Date: Wed, 25 Sep 2019 22:08:00 -0000 In-Reply-To: <0dcd5cbc1c863f32bbc513db657e3c2aec2dadb7.1569425799.git.andrew.burgess@embecosm.com> (Andrew Burgess's message of "Wed, 25 Sep 2019 16:54:25 +0100") Message-ID: <87lfucf2qs.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-09/txt/msg00492.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: Andrew> Removes a use of VEC from dwarf2read.{c,h} and replaces it with Andrew> std::vector. As far as possible this is a like for like replacement Andrew> with minimal refactoring. Andrew> + if (tu_group->tus == nullptr) Andrew> + tu_group->tus = new std::vector ; Andrew> + tu_group->tus->push_back (sig_type); Andrew> + int len = tu_group->tus->size (); Is it possible to reach here with tus==nullptr? Andrew> + for (i = 0; i < tu_group->tus->size (); ++i) Likewise. Andrew> - VEC_free (sig_type_ptr, tu_group->tus); Andrew> + delete tu_group->tus; VEC_free resets tus to nullptr, but I don't know whether or not that's important. Tom