From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82299 invoked by alias); 28 Feb 2020 18:58:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 82286 invoked by uid 89); 28 Feb 2020 18:58:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=Anyway, H*f:sk:875zfqr, H*i:sk:875zfqr X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.143.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Feb 2020 18:58:33 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway31.websitewelcome.com (Postfix) with ESMTP id A2CC14B2D5 for ; Fri, 28 Feb 2020 12:58:31 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 7kqFj227eSl8q7kqFjfyYt; Fri, 28 Feb 2020 12:58:31 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/hTMry+1d0l2JAmMyiznkOlnxUakM3HM0/Ze4a6H6SU=; b=HQHqbZZtuf8hU1M6dKmkUh+iZ0 0RF8qiHNZjkajU2tV66uh2qVQ9W5q+ryMV3s5FJLn+h61sp828InsndalrqaEBoeNK6agHb0Jowjs lZ7HYMeSmad8z+wrIoC9O+kyj; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:40014 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1j7kqF-0013g3-8h; Fri, 28 Feb 2020 11:58:31 -0700 From: Tom Tromey To: Sergio Durigan Junior Cc: Tom Tromey , GDB Patches , Pedro Alves , Eli Zaretskii , Ruslan Kabatsayev Subject: Re: [PATCH 2/6] Don't reset errno/bfd_error on 'throw_perror_with_name' References: <20190926042155.31481-1-sergiodj@redhat.com> <20200226200542.746617-1-sergiodj@redhat.com> <20200226200542.746617-3-sergiodj@redhat.com> <87wo86ivbu.fsf@tromey.com> <875zfqr7mz.fsf@redhat.com> Date: Fri, 28 Feb 2020 18:58:00 -0000 In-Reply-To: <875zfqr7mz.fsf@redhat.com> (Sergio Durigan Junior's message of "Fri, 28 Feb 2020 11:36:36 -0500") Message-ID: <87lfomilnt.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-02/txt/msg01065.txt.bz2 >>>>> "Sergio" == Sergio Durigan Junior writes: >> I didn't understand why this one was needed. >> Does safe_strerror reset errno? Maybe a comment would be in order. Sergio> Ah, no, safe_strerror doesn't reset errno. As I explained in the commit Sergio> message, it is not allowed to do so. The reason I decided to explicitly Sergio> save/restore errno is because I wanted to make sure that we (also Sergio> explicitly) follow the same rules for both GDB and gdbserver perror Sergio> functions. But now I'm left thinking that I should have proposed the Sergio> same thing for 'throw_perror_with_name'... Sergio> Anyway, I'm fine with removing the save/restore from gdbserver's Sergio> perror. I'll also remove the reference to it in the commit message. The main thing for me is that when someone sees this in 5 years, that there's some idea of why the line is there. Leaving the line out is just as good :) thanks, Tom