From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 0) id D9F603875DFD; Fri, 20 Mar 2020 16:02:19 +0000 (GMT) Resent-From: Christopher Faylor Resent-Date: Fri, 20 Mar 2020 16:02:19 +0000 Resent-Message-ID: <20200320160219.GC31709@server2.sourceware.org> Resent-To: gdb-patches@sourceware.org Received: from gateway36.websitewelcome.com (gateway36.websitewelcome.com [192.185.186.5]) by sourceware.org (Postfix) with ESMTPS id A38D9387703A for ; Fri, 20 Mar 2020 15:54:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A38D9387703A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 769EE409D38F0 for ; Fri, 20 Mar 2020 10:10:41 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id FJyljjxp9VQh0FJyljyolv; Fri, 20 Mar 2020 10:54:35 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=v0i2FDCsVh+XD77Iquw0PZ0HiMMHGtxrYvSyOdPD3XI=; b=OStQYF5t6fcUj4ZDrdlCB6kAR2 Z9hmNfBRaNBMby7amnPBBQJI9BMAeBEOitJF+f67Eab83ruwpGTKXXt3yA4mQwiYJNNrZ5ZNLUlLZ iJ66etjRb1gD+RG4fs75bYXfN; Received: from 97-118-117-21.hlrn.qwest.net ([97.118.117.21]:43072 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jFJyk-000LEU-QO; Fri, 20 Mar 2020 09:54:34 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH] gdb: remove HAVE_DECL_PTRACE References: <20200319152742.2495-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Fri, 20 Mar 2020 09:54:34 -0600 In-Reply-To: <20200319152742.2495-1-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Thu, 19 Mar 2020 11:27:42 -0400") Message-ID: <87lfnvkon9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Mar 2020 16:02:19 -0000 >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> I stumbled on this snippet in nat/gdb_ptrace.h: Simon> /* Some systems, in particular DEC OSF/1, Digital Unix, Compaq Tru64 Simon> or whatever it's called these days, don't provide a prototype for Simon> ptrace. Provide one to silence compiler warnings. */ Simon> #ifndef HAVE_DECL_PTRACE Simon> extern PTRACE_TYPE_RET ptrace(); Simon> #endif Simon> I believe this is unnecessary today and should be removed. First, the Simon> comment only mentions OSes we don't support (and to be honest, I had Simon> never even heard of). Thanks, this looks good to me. Tom