From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway20.websitewelcome.com (gateway20.websitewelcome.com [192.185.66.3]) by sourceware.org (Postfix) with ESMTPS id 92AE6385BF92 for ; Wed, 1 Apr 2020 20:43:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 92AE6385BF92 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 68B3F400C5948 for ; Wed, 1 Apr 2020 14:27:41 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id JkDGjurnGEfyqJkDGjreIs; Wed, 01 Apr 2020 15:43:50 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=43QoooWctZGlNmP2pJbuRWPOW0Bbk5Y4le4/LY1fXwI=; b=B7vpcAYZc7Olt9kM4fXDt8yMiD HXs+IrcFuYyYYS2q7HjG4Fgf963o5MyJpfvfvOreus9zhMGTRYAIk+g5+hYz3qcRcvrBXtPzMK+EY dQPKDTxtU4qYQABxHm2HlVNp0; Received: from 97-118-117-21.hlrn.qwest.net ([97.118.117.21]:33924 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jJkDF-002UFj-VH; Wed, 01 Apr 2020 14:43:50 -0600 From: Tom Tromey To: Kamil Rytarowski Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Implement basic threading support in the NetBSD target References: <20200326025314.2392-1-n54@gmx.com> X-Attribution: Tom Date: Wed, 01 Apr 2020 14:43:49 -0600 In-Reply-To: <20200326025314.2392-1-n54@gmx.com> (Kamil Rytarowski's message of "Thu, 26 Mar 2020 03:53:14 +0100") Message-ID: <87lfnfym0q.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.117.21 X-Source-L: No X-Exim-ID: 1jJkDF-002UFj-VH X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-117-21.hlrn.qwest.net (murgatroyd) [97.118.117.21]:33924 X-Source-Auth: tom+tromey.com X-Email-Count: 12 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2020 20:43:52 -0000 >>>>> "Kamil" == Kamil Rytarowski writes: Kamil> Use sysctl(3) as the portable interface to prompt NetBSD threads on Kamil> all supported NetBSD versions. In future newer versions could switch Kamil> to PT_LWPSTATUS ptrace(2) API that will be supported on NetBSD 10.0 Kamil> and newer. Thank you for the patch. Kamil> +static void Kamil> +nbsd_thread_lister (const pid_t pid, Kamil> + std::function callback) Perhaps a const reference here would be better. Or maybe gdb::function_view, I'm not sure. Kamil> + /* Return true if the specified thread is alive. */ Kamil> + auto lwp_alive = Kamil> + [&l]() Kamil> + { Kamil> + switch (kl->l_stat) Kamil> + { Kamil> + case LSSLEEP: Kamil> + case LSRUN: Kamil> + case LSONPROC: Kamil> + case LSSTOP: Kamil> + case LSSUSPENDED: Kamil> + return true; Kamil> + default: Kamil> + return false; Kamil> + } Kamil> + }; Kamil> + Kamil> + /* Ignore embryonic or demised threads. */ Kamil> + if (!lwp_alive (l)) Kamil> + continue; I don't think a lambda is needed here. Kamil> +bool Kamil> +nbsd_nat_target::thread_alive (ptid_t ptid) Kamil> +{ Kamil> + pid_t pid = ptid.pid (); Kamil> + int lwp = ptid.lwp (); Kamil> + bool found = false; Kamil> + Kamil> + auto fn = Kamil> + [&lwp, &found] (const struct kinfo_lwp *kl) Kamil> + { Kamil> + if (kl->l_lid == lwp) Kamil> + { Kamil> + found = true; Kamil> + return true; Kamil> + } Kamil> + return false; Kamil> + }; Kamil> + Kamil> + nbsd_thread_lister (pid, fn); Kamil> + Kamil> + return found; A classic pattern in gdb is to have one of these iteration functions (here, nbsd_thread_lister) return bool and have it return true if any callback returns true, and false otherwise. That would eliminate this "found" variable. Kamil> +const char * Kamil> +nbsd_nat_target::thread_name (struct thread_info *thr) Kamil> +{ Kamil> + static char buf[KI_LNAMELEN] = {}; ... Kamil> + return buf; This should return NULL if no name was found. The above bool return would make this easy as well. Kamil> + fprintf_unfiltered (gdb_stdlog, "NLWP: pid=%d lwp=%d\n", pid, kl->l_lid); This line should be removed. Tom