From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway23.websitewelcome.com (gateway23.websitewelcome.com [192.185.49.218]) by sourceware.org (Postfix) with ESMTPS id 9B7A93952501 for ; Wed, 22 Apr 2020 21:13:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9B7A93952501 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 24CE092B4 for ; Wed, 22 Apr 2020 16:13:52 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id RMgqjCNpaAGTXRMgqjW66V; Wed, 22 Apr 2020 16:13:52 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7Jlgxw5rAwuQW90/58IUojXZ9edxp2HE1VpGtDrSGQQ=; b=MHblnxkdtSn6b7rQEl1HRHA8oX c+xMmeVDwvYeF6ldnLg/T5EX/e1qhFPbqddkzBDk4s6scuRTKjeZ7TjSkgWJb+qlRHIkZzLbmxdtz iaYo1ZNvClAMW3L8P5dpCSrrl; Received: from 184-96-229-138.hlrn.qwest.net ([184.96.229.138]:44658 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jRMgp-000g01-TN; Wed, 22 Apr 2020 15:13:51 -0600 From: Tom Tromey To: Andrew Burgess Cc: Bernd Edlinger , Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] gdb: Preserve is-stmt lines when switch between files References: <6e9b21a0002164cec014dfe4d94d816a376989b4.1585952198.git.andrew.burgess@embecosm.com> <20200414112841.GC2366@embecosm.com> <20200416171809.GJ2366@embecosm.com> X-Attribution: Tom Date: Wed, 22 Apr 2020 15:13:51 -0600 In-Reply-To: <20200416171809.GJ2366@embecosm.com> (Andrew Burgess's message of "Thu, 16 Apr 2020 18:18:09 +0100") Message-ID: <87lfmnql4g.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 184.96.229.138 X-Source-L: No X-Exim-ID: 1jRMgp-000g01-TN X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 184-96-229-138.hlrn.qwest.net (murgatroyd) [184.96.229.138]:44658 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Apr 2020 21:13:54 -0000 >>>>> "Andrew" == Andrew Burgess writes: I read through the various threads on this topic, though I think maybe not very well. IIUC, the issue at hand is that there are two proposed patches to fix various issues in this area. Andrew's patch takes us roughly to the status quo from before is-stmt landed. This patch takes the view that GCC is currently buggy, so one test is partly disabled; and there's a new bug so we can fix GDB once GCC is fixed. Bernd's patch takes the view that GCC won't be fixed and tries to work around the problem; it drops at least one "FILE:LINE" case that currently works. Is that a fair summary? There were many messages and details, so I'm not sure I either understood it all or that it can be summarized like this. If that's fair, then my inclination is to move forward with Andrew's patch for the time being, with the primary justification being conservatism. Bernd's patch can always land if/when we have some clarification from GCC about whether the bugs there will be fixed. Let me know what you think. Tom