From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway32.websitewelcome.com (gateway32.websitewelcome.com [192.185.145.1]) by sourceware.org (Postfix) with ESMTPS id AE5F5386F471 for ; Fri, 22 May 2020 20:15:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AE5F5386F471 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 4670720774 for ; Fri, 22 May 2020 15:15:18 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id cE4cjuB22AGTXcE4cj8Ms8; Fri, 22 May 2020 15:15:18 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VmTVaqAER61Tkhg1FKqZSgNb7kVuKu3Bes0eMPv8gys=; b=obemxHIroJGlsWTRGYEw7Fdudh 3Z23zMqA6UYFlWQ0bbVbfkK8xiU1JXoRkr1FobRXsgYtkFPoX0jiMj2fQT08mAkHddsSNCtQ4xvuR 8hr3R6q/JMPfCtvl0o7D68UPg; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:36028 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jcE4c-003n2D-0s; Fri, 22 May 2020 14:15:18 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/3][gdb/testsuite] Warn about leaked global array References: <20200519163004.GA9045@delia> X-Attribution: Tom Date: Fri, 22 May 2020 14:15:17 -0600 In-Reply-To: <20200519163004.GA9045@delia> (Tom de Vries's message of "Tue, 19 May 2020 18:30:06 +0200") Message-ID: <87lflj3ewa.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jcE4c-003n2D-0s X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:36028 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 May 2020 20:15:19 -0000 >>>>> "Tom" == Tom de Vries writes: Tom> So, since a global name in one test-case can leak to another Tom> test-case, setting a global name in one test-case can result in Tom> a tcl error in another test-case that reuses the name in a different Tom> way. Tom> Warn about leaking a global array from a test-case. This seems fine to me. Tom> Also, add a possibility to skip the warning in a given test-case using Tom> variable gdb_skip_check_global_vars, and use it in gdb.mi/mi2-var-child.exp Tom> and gdb.mi/mi-var-cp.exp. Is that because these tests are still buggy in this way, or something deeper? Tom