From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by sourceware.org (Postfix) with ESMTPS id 535583857C7D; Tue, 25 Aug 2020 12:33:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 535583857C7D Received: by mail-wm1-x341.google.com with SMTP id x9so1949012wmi.2; Tue, 25 Aug 2020 05:33:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=/OsnmACIiUU4e7Eb6MQPz4tg836pedFjnBbO5pfTRxA=; b=bQNnhm+qzUEI7S1A0Etc46fta9zScBPbgoX4f2/SxAjkv+F9xzZbiHFGWSh8iAT1Xt 2snSgd92fcNi97TM21sAXJzSeQevnOwixnbjQs5me3v3e3d9fnT0eDFOlabT4+UPtL2Q aSvON0GjyYsmbDYwje1PdNb8F46aeMbnop5M1AWVGhS4j77HS+dplQDGzdqTSPqujW2+ tOAmPxDXv2Cm8Ba9gPX2xxZ9zQJ1aLOAKgQcEnJP9pD3CJM2z1NbvajA9epKTGPi071Y HFvDYQ/S7UrNnRMilR4H98aBpakNCZ7HnnA61vLm29H1QU5YvNgQ2YzFSzhL5ZsvX3D7 cryA== X-Gm-Message-State: AOAM533tpeAgsvRwCFZVmxRe37/Gf/lmpsVnjskZxhe6eKZEnku0NfDX Di3rXjUj9p+VZTVdHKCZ9/n4aZ/Ru/0= X-Google-Smtp-Source: ABdhPJxZZEe7ayJvpYn6xmXrZjizyU+j5vpqqTWzI8k7kRGt/tQ+qdGPI4QwlYd7NsWrhm2rFnPavw== X-Received: by 2002:a1c:9883:: with SMTP id a125mr1950650wme.133.1598358808206; Tue, 25 Aug 2020 05:33:28 -0700 (PDT) Received: from ettard ([195.147.220.46]) by smtp.gmail.com with ESMTPSA id x133sm5815557wmg.39.2020.08.25.05.33.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2020 05:33:27 -0700 (PDT) From: Gaius Mulley To: Andrew Burgess Cc: Tom de Vries , gdb@sourceware.org, gdb-patches@sourceware.org Subject: Re: Patch: Fix for Bug 26372 [Modula-2] Parsing of multi-subscript arrays References: <878se3xxtr.fsf@ettard> <9d68a12b-0df4-9ee8-540d-376f20732754@suse.de> <20200825093613.GT853475@embecosm.com> Date: Tue, 25 Aug 2020 13:33:26 +0100 In-Reply-To: <20200825093613.GT853475@embecosm.com> (Andrew Burgess's message of "Tue, 25 Aug 2020 10:36:13 +0100") Message-ID: <87lfi2gb1l.fsf@ettard> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Aug 2020 12:33:30 -0000 Andrew Burgess writes: > * Tom de Vries [2020-08-25 11:29:18 +0200]: > >> On 8/25/20 4:29 AM, Gaius Mulley wrote: >> > >> > >> > Hi Tom, >> > >> > here is a bugfix for Pr 26372 [Modula-2] Parsing of multi-subscript arrays. >> > Also included is a dejagnu testcase. No extra regressions are caused on >> > Debian GNU/Linux Buster amd64, is this ok to apply? >> > >> >> Hi Gaius, >> >> I ran into some trouble applying the patch with the patch program, so I >> applied the patch manually, and then diffed the result of that with the >> original patch and fixed whitespace problems in the original patch until >> I got duplicates, to ensure that the application process was sane. >> >> I verified that when building with the patch, the warning "rule useless >> in parser due to conflicts" is gone, and no new warnings are introduced. >> >> I ran the test-case and verified that it failed without and passed with >> the patch. >> >> I've also fixed the ChangeLog entry a bit (multidim.y -> multidim.exp) >> and split it up for gdb/ChangeLog and gdb/testsuite/Changelog, as well >> as added a PR number. >> >> I've gone ahead an applied it (with you as author, obviously). See >> https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=07758bdfa9e5a762f2ec0deeb51b11d6ad5fe376 >> . >> >> Attached here for reference. > > Given the issues I raised with this patch in [1] I reverted this > commit and pushed my suggested patch instead. Again maintaining the > original author. > > I hope this does not offend anyone. Please let me know if this was > the wrong course of action. > > Thanks, > Andrew > > [1] https://sourceware.org/pipermail/gdb-patches/2020-August/171456.html Hi Andrew and Tom, many thanks for reviewing and testing the patch, improving the patch and applying it. All looks great now, regards, Gaius