From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KG6uFfhiO2Z1pAoAWB0awg (envelope-from ) for ; Wed, 08 May 2024 07:33:12 -0400 Received: by simark.ca (Postfix, from userid 112) id 537651E0C1; Wed, 8 May 2024 07:33:12 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3F26E1E030 for ; Wed, 8 May 2024 07:33:10 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E53853890017 for ; Wed, 8 May 2024 11:33:09 +0000 (GMT) Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by sourceware.org (Postfix) with ESMTPS id 45C84385E836 for ; Wed, 8 May 2024 11:32:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 45C84385E836 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=jetbrains.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=jetbrains.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 45C84385E836 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715167972; cv=none; b=jlb4EOqGRPPlbSiaOgh3NRy5zV6wi2I9Kf43fm9JcqsfF7QY3RJ5X1ICfgXjpSjflaaMqwKBkANmB7N4d56wzAOsm049zFO0vxOlejhf2Pd/vttXJUlEPXwjbKwbw1Avf7PSqTeJCg9/N0/MI4yKPYXcqKhIv+stxbpjNpOWW3A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715167972; c=relaxed/simple; bh=2sVqk2ulC7booVpqoIm7AsWsIivW7zq0UQWgSFQEpcE=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=QXRU2NLCrjUv1/6ggUojdnZdltr20LtQkS9EwYCi6H3fkSsCSq+bELvjk12inMBCDVCqv3GOCiuJynI6AurflKC89DVoAZy5Ybb11cZbNZYpPJK4Ng5VcUGoFLoe288JRuvTQrxCm+xlpId7Ys1PzTp4Cy21jQD+A/tB2QgL7MM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-34e667905d2so3201249f8f.1 for ; Wed, 08 May 2024 04:32:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715167969; x=1715772769; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xslKGduIDtvDM1As97rM5Vg4p+VjXvJ/ztYAqKIDCRY=; b=oI+CNW1cWlxlCNg17Id3H/IoQWamrRjOsKxKjHJHxK/mxTfaJaXtwybm1/oyZMaAJH FwqsqSo7vx+DiGbJc8YK3MTLGGh1z2z+017qYzMKb8t1heb/ZeeU69FfJvzIyt6JqRlV pxQAEMy/HNzKT4o0Jyub7vr/19UwJgzaWmU8hMRfgVepz+/Noi2GyK+11JklxCrohxeA n7WmhgQqXjqYnZVXK2DoHGLlkPw3vHM+DdXfSVFMy0NXc76qjZMclP32a0CoxT2+oADL iLTGP8AIp2FBdxibat7c0q3fK8S6UiDDFJRf/Sonlcumrs+ZJfxQt4z+thuwuu/QRezu ljkA== X-Gm-Message-State: AOJu0YyuOsdPQQjZzJ8OkLpS2RvsupN0r4JqGO/Y2s8pWQJ5DnVCHdHN C6snkOgAOybBbvsz77OTI30yX3ayiGbh9qGY8LLZqwtGPCKLr3NdTZHx5AeEUz//wWzaHFjBLNE = X-Google-Smtp-Source: AGHT+IEpPJwTfVVa/sVV+2iJsaJmP2EDWwbUyC7ooftfrlyKTV5afZfcpIpz4RE6OLPpucLwJx69Ug== X-Received: by 2002:a5d:69ca:0:b0:34e:182f:62ed with SMTP id ffacd0b85a97d-34fcb3abb03mr2185144f8f.61.1715167968889; Wed, 08 May 2024 04:32:48 -0700 (PDT) Received: from lubuntu2 (ad96e1c12.dsl.de.colt.net. [217.110.28.18]) by smtp.gmail.com with ESMTPSA id g1-20020a5d6981000000b0034d8b0b5329sm15134382wru.87.2024.05.08.04.32.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 May 2024 04:32:48 -0700 (PDT) From: Dmitry.Neverov To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3][PR symtab/30520 1/4] gdb/symtab: check name matches before expanding a CU In-Reply-To: <87edada70o.fsf@tromey.com> References: <20240506150920.1220092-1-dmitry.neverov@jetbrains.com> <87edada70o.fsf@tromey.com> Date: Wed, 08 May 2024 13:32:47 +0200 Message-ID: <87le4kmtcw.fsf@lubuntu2.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Tom Tromey writes: > Dmitry> + symbol_name_matcher_ftype *name_matcher > Dmitry> + = lang_def->get_symbol_name_matcher > Dmitry> + (last_segment_lookup_name); > > This also looks weird by gdb rules. Do I understand correctly that it should look like this: symbol_name_matcher_ftype *name_matcher = lang_def ->get_symbol_name_matcher (last_segment_lookup_name); ? How do I send an updated patch? I've read the Contribution Checklist, but didn't find the answer. Do I amend the commit and 'git send-mail' it again with proper '--in-reply-to'? -- Dmitry