From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Andrew Burgess <aburgess@redhat.com>,
gdb-patches@sourceware.org,
Guinevere Larsen <guinevere@redhat.com>
Subject: Re: [PATCH] gdbserver: convert program_args to a single string
Date: Tue, 14 Jan 2025 10:23:48 -0700 [thread overview]
Message-ID: <87ldvdqpgb.fsf@tromey.com> (raw)
In-Reply-To: <b30942e2-d865-48b0-bdd0-80dbcc540981@simark.ca> (Simon Marchi's message of "Tue, 14 Jan 2025 10:32:58 -0500")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>> /* Start a new process.
>> PROGRAM is the program name.
>> - PROGRAM_ARGS is the vector containing the inferior's args.
>> + PROGRAM_ARGS is a string containing all the inferior's arguments.
>> Returns the new PID on success, -1 on failure. Registers the new
>> process with the process list. */
Simon> I think this comment should just be removed, there's no point in
Simon> repeating the documentation from the base class.
FWIW I normally consider the "override" keyword to be sufficient
documentation in these cases; though there's also some code with a
comment pointing at the base class.
Tom
next prev parent reply other threads:[~2025-01-14 17:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 13:39 Andrew Burgess
2025-01-14 15:32 ` Simon Marchi
2025-01-14 17:23 ` Tom Tromey [this message]
2025-01-14 17:34 ` Simon Marchi
2025-01-14 23:07 ` Tom Tromey
2025-01-15 10:21 ` Andrew Burgess
2025-01-15 10:09 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ldvdqpgb.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=guinevere@redhat.com \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox