From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id vUKIAqFhjmcygBUAWB0awg (envelope-from ) for ; Mon, 20 Jan 2025 09:45:53 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YcoT50xm; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id ED8FF1E100; Mon, 20 Jan 2025 09:45:52 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4633B1E08E for ; Mon, 20 Jan 2025 09:45:52 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 43B0E385801B for ; Mon, 20 Jan 2025 14:45:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 43B0E385801B Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YcoT50xm Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id ECC9B3858C5F for ; Mon, 20 Jan 2025 14:44:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ECC9B3858C5F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ECC9B3858C5F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737384253; cv=none; b=QwAC8tyYT62t9YZ82sXfV9BgukAZCqUJT1qIJ95DnaF/onwoUZ8fWVVTFkQHjTG/EpnPWXfOujuvZ/BXJoj9YcxGqNzQv91D3sGu2Ebs/tEV1ypmTxGaf6fOfUyufzWw18KmTcehyDIZLo3wlTwHNjIANuVi9FU2Uv/iqc5Y7O4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737384253; c=relaxed/simple; bh=qjkEBI5m1tOtl56j1RfGMdTzsSkwt67JvFqW+2IEW/E=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=pGqVU00lFANthFk9k7jRL85Mg7l3e0vm5WlpBAwNdO+d7grjQ6DJElsdlWWbe+82r9PGSp1hopuvehQTiVD+NfA9zHi387igLvqYOK8fHed6K9Nf2CK8V4vXZV6YLHyQnKhM4bUCcdZKxuFNkoCi1UyhIiXL6G4DJihBdVZjYR0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ECC9B3858C5F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737384252; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QlDOeWqqd6lQ34FzUu8yeZvt39rlwWs/rG3fHuhL/CA=; b=YcoT50xmI+MQbW6nqEW9PU02aTVyRyicCPD2SCmNB7qDweu9YTTfeP3zqDGsnGTiEOkzAn k87qxW9WGXN4p/N4zvyKQEGGDO/AdkwGtohZOS1AvEhaJgt9QI5hqh3QXhkz9vgjqLKSMI vYxZGmcXg/LIrQxUtEs2CmWfdyOwHG0= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-644-oruYFjqlNEeiT4Cq1of_4Q-1; Mon, 20 Jan 2025 09:44:11 -0500 X-MC-Unique: oruYFjqlNEeiT4Cq1of_4Q-1 X-Mimecast-MFC-AGG-ID: oruYFjqlNEeiT4Cq1of_4Q Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43673af80a6so35832595e9.1 for ; Mon, 20 Jan 2025 06:44:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737384250; x=1737989050; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QlDOeWqqd6lQ34FzUu8yeZvt39rlwWs/rG3fHuhL/CA=; b=YTNu6IpLkWFUWkKjZrtcDzArhCTvyiej+CoaT3xR0QjZJoAhgd09uy6PuBkZeyCjHe YwnblSt7RBw3HWERs3ousOQfm1g7zjKYzr4Kb8q75mevSS7l4/JqiRjiEkidCVlkagT1 6mQFEpR7EF9vk8mvri2kRTQBWmp5/hPn52ZCi9RM92SlsrCrKmHZV1u5Wo4lDdUkJivz bJpWAkN0vQ+QLsKry+OStb6Gw4mZAex7qbM8XZUl5R8ylxVQXU++bUpiIj9cK89uJjmX GgP7H6+GzmkqpA59mISkkBCoF+3fYUACc4SRPWk57zy8aiGqtLMdnGYiwweGTEdNT9Wq 9Nhg== X-Gm-Message-State: AOJu0Yy/W/NVrblqi1O2onJE8SYKwdDJ7i3GTJmIqGPPO3g2auIZ82TF qb35bg+URe2hkwNCabUHnxoglDpfmexsYwtwvGC3tTUSaGAMcznzVMhKMgu6lDnn6B0a1XcEc62 6HtcDiiZoPmE0bBbukYNWMrnTm92FSQkSEgTzl8E929oVQqhqQnFr4BhAH+PGUgZSdnA= X-Gm-Gg: ASbGncvp4PhrfKi/c67PihQzOoV5fEjLW4IPkGdcpFYtpTgQgRJNA8URd5JVvH9A4Ch gJAPklg+/LNyeZ2z5cDXhYlTLMUmmfVuoz6LmjRL5RCc7IYFs9cARhZQ0psORucMc3tZB+SkCzX elB8gn+AuXUHDDYVIBhFdW5RXZJknTjBH3POct/Nrl5hYWfFwKbKjBJT/em9nXzY9sEexIRrllk 9spWkU8AHMBOfkJB12s3cJjhkddVSeq4p4fONupVS/SCOTq+2SsGTtkXBjE50pgBfFLyNY7WtiI wowMT10EkJdlx9DZ2gk= X-Received: by 2002:a05:600c:5027:b0:434:f5c0:3288 with SMTP id 5b1f17b1804b1-43891430ed1mr123613765e9.29.1737384250056; Mon, 20 Jan 2025 06:44:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IFGPrShapT17X1rcu4qCnM8Q3VSoJsOb8xSfRTguxHlIbzoreeU2ED4ls/JHZujEnFPMGBXqw== X-Received: by 2002:a05:600c:5027:b0:434:f5c0:3288 with SMTP id 5b1f17b1804b1-43891430ed1mr123613575e9.29.1737384249605; Mon, 20 Jan 2025 06:44:09 -0800 (PST) Received: from localhost (44.226.159.143.dyn.plus.net. [143.159.226.44]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf322ad81sm10763338f8f.52.2025.01.20.06.44.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2025 06:44:09 -0800 (PST) From: Andrew Burgess To: Brandon Belew Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [PR corefiles/32441] Fix segfault if target_fileio_read_alloc fails In-Reply-To: References: <87v7ueog73.fsf@redhat.com> Date: Mon, 20 Jan 2025 14:44:08 +0000 Message-ID: <87ldv5mton.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: _9bgjEiIZvouiJ_rAaneQyDEqg-eemRtxcz5-8rV1Hk_1737384250 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Brandon Belew writes: > Andrew Burgess writes: >> I think you should reconsider here. The function returns LONGEST, so >> that's what should be used. GDB's general policy is to fix little >> bugs like this as the code gets touched for other reasons. > > Thanks Andrew! I'll go back and look at the LONGEST return value and get > back to you on that with an updated patch. To be clear, you want the > other function that was already using ssize_t for the return fixed as > well?=20 > >> Otherwise, I agree with Luis, this looks great. If you repost with the >> description in the commit message we can get this merged. > > I replied to Luis' message with some further questions about > formatting. For reference, my original reply has a Message-ID of > hwjgya7c6ulo46.fsf@brandonb.zetier.com. I'll redo those questions here: > > It was my understanding of git-format-patch / git-send-email (and in > reverse, git-am) that the commit message would be taken from everything > up to the '---'. Then everything between the '---' and the actual diff > was considered "timely commentary" and would not be present in the > commit message. This typically contains the diffstat output but also is > used for commentary on the patch that shouldn't go into the commit > itself. > > As described in https://git-scm.com/docs/git-format-patch: >> Typically it will be placed in a MUA=E2=80=99s drafts folder, edited to = add >> timely commentary that should not go in the changelog ***after the >> three dashes*** [emphasis added]=20 > > And also as described at > https://spacekookie.de/blog/collaborating-with-git-send-email/: >> Another often overlooked feature here is "timely commentary", are >> comments in the patch e-mail that won't be part of the patch or the >> commit message itself. They can be made after the --- marker in a >> patch mail, but before the actual patch starts. This section is >> usually used for the diff-stat of that particular patch. > > I tried sending the patch email to myself before I sent it to the list, > piping it to `git-am`, and it correctly applied the commit without my > "timely commentary", so I was pretty convinced I had formatted it > correctly. > > Do you get something different when you `git am` my message? If so, can > you be more specific about how I need to reformat the email? I guess if that works, then it's fine. It's not a layout I've seen before, and it doesn't make much sense to me. That is, placing the email reply between the commit message and the patch seems an odd ordering to me, I'd usually reply to the various points, and then just place the patch, including commit message, and the tail of the email. But thanks for referencing the actual docs. Thanks, Andrew