From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id XSWKOq9c2Wf20RMAWB0awg (envelope-from ) for ; Tue, 18 Mar 2025 07:44:47 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=D2HUZ+eq; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id DE7CE1E100; Tue, 18 Mar 2025 07:44:47 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8647F1E0C0 for ; Tue, 18 Mar 2025 07:44:47 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 31B543857BBF for ; Tue, 18 Mar 2025 11:44:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 31B543857BBF Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=D2HUZ+eq Received: from omta034.useast.a.cloudfilter.net (omta034.useast.a.cloudfilter.net [44.202.169.33]) by sourceware.org (Postfix) with ESMTPS id 0C188385840C for ; Tue, 18 Mar 2025 11:43:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0C188385840C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0C188385840C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742298202; cv=none; b=Kov5WqObAWzgUhQgj23SN6S2Bvk78M+dfKBVEqSr3gSkHAQXLTXp8Qndrgihj/JHVpH3HfhD5F4Evc7jekEPFJgaYWjIXxT/sc2UAUzxOrQdjRbcdBJWolg4sB5+n0kFT3s9vQJiOaPEmx978Y6NFDWTlx4HNbFee8z+Yp2L53Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742298202; c=relaxed/simple; bh=6QZW2WTAlLe58KLGvIdROGl/zLkWfCLDnY4QW8qRhRQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=u9591J3mBACrkmzB1pdnE6CgilMNuxuv/DuLlkOtNahnvSmC0lOUUG7L9ov1Lym76F5c7Ya5D/WvtwwmS0EwJ9Qgs557mBCZph7ULVYmmjl5l/W171AfnusShjWduKTHppxPazuDyj5Cl+Ar3m/Ag3bdGg9Eh0aJt8rlBHIBiio= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0C188385840C Received: from eig-obgw-6004a.ext.cloudfilter.net ([10.0.30.197]) by cmsmtp with ESMTPS id uJuGt41LUXshwuVLttXJQQ; Tue, 18 Mar 2025 11:43:21 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id uVLstIRhdRlrsuVLttzFuQ; Tue, 18 Mar 2025 11:43:21 +0000 X-Authority-Analysis: v=2.4 cv=Qamtvdbv c=1 sm=1 tr=0 ts=67d95c59 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Vs1iUdzkB0EA:10 a=ItBw4LHWJt0A:10 a=7d_E57ReAAAA:8 a=CsJLT02bzMh2D43VlkMA:9 a=jhqOcbufqs7Y1TYCrUUU:22 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=zCU2FRoZc1HVxm+J7T2Qsi4TXCBPhNP/9vPc6dJn+w8=; b=D2HUZ+eqbfJej15SVqXQcNqT+Z 8iv1IHkEZHd5JRirBmrFZWqt1ROvlFeFGqr2iOlXp7SaK336J+njNnUGd9OVacX6UtvldthHDc79V O4PwqVSjgTF/YRB6VjYG/J881; Received: from 97-122-123-18.hlrn.qwest.net ([97.122.123.18]:56664 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1tuVLs-000000030Zc-22sp; Tue, 18 Mar 2025 05:43:20 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 00/19] Convert std::unordered_{set,map} to gdb implementations In-Reply-To: <0cbb4330-b9b1-44d2-b0bc-53e1f25044f5@simark.ca> (Simon Marchi's message of "Mon, 17 Mar 2025 23:27:58 -0400") References: <20250317-replace-std-stuff-v1-0-7ba4ee88e218@tromey.com> <0cbb4330-b9b1-44d2-b0bc-53e1f25044f5@simark.ca> X-Attribution: Tom Date: Tue, 18 Mar 2025 05:43:18 -0600 Message-ID: <87ldt2tvhl.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.123.18 X-Source-L: No X-Exim-ID: 1tuVLs-000000030Zc-22sp X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-123-18.hlrn.qwest.net (prentzel) [97.122.123.18]:56664 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfMQz3/CPsU9+oWUXtj2TFwT8aIHAE4xsLWMwloBatASaQ54BQOXMWxip0yWM70Xsxh+KiqU+IctCQAUgzGS/aHO1otAMRyrgWqgZrEksEWs8igJgp3i3 c6VnYBfIyfo21alqIp1swSLR71oQTEC94vdLtZiMWTdejdgO33QaIDe0j9TfyzsXgI4Lv3p8lFURCeiJPUpkniD3jxOmg4//XmM= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon> Modulo the minor questions/comments I sent, this LGTM. Most of it is Simon> 1:1 replacement, so it's relatively trivial. Simon> Approved-By: Simon Marchi Rather than send a v2 just for the hash change, I'm just going to check it in, since as you say it's largely trivial. thanks, Tom