From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 5UVZCX5kN2jmPTgAWB0awg (envelope-from ) for ; Wed, 28 May 2025 15:31:10 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=mAWzn0FQ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 11B3A1E11C; Wed, 28 May 2025 15:31:10 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-8.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6AE3E1E102 for ; Wed, 28 May 2025 15:31:08 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 14A093856DFA for ; Wed, 28 May 2025 19:31:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 14A093856DFA Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=mAWzn0FQ Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id B62EE385C418 for ; Wed, 28 May 2025 19:30:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B62EE385C418 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B62EE385C418 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1748460610; cv=none; b=T+71T1pzN4S1AzVyAVym+AaLRtov6Tbx6+e8PKbV+Wi5DROkMxEWwPR48oecywFwDitKjkdWThkD1WBtY/GS6cSQzsm18zn80HUIdTkNR4I3Y2zysqHJOfyMcFygip5Cjegfl97sMnJBPPgp4VoEPW0FqYLgTJXCRP/uV0P77cE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1748460610; c=relaxed/simple; bh=W/KiGIx+lx2PYzuEGpS9t4wu5syt84tN+y0SmCEkk7k=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=QUYAyYp4HCahdKP4NH0FqHewa3BOGSJuBVACy/W0WvMkQJVT89THugYCbW2a/tEVQr9ghXeCQLMEoL5q9RpOLhlxNEEGatkHwaV41eClSLsYqPY9sw8yEHf4tJbCM4t8W3RL8V6m5Ax1eTvsUN3AcLE/nujf7E/2cV4FIx7QhaQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B62EE385C418 Received: from eig-obgw-6001a.ext.cloudfilter.net ([10.0.30.140]) by cmsmtp with ESMTPS id KFS3uNwA5VkcRKMTaudAyS; Wed, 28 May 2025 19:30:10 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id KMTZuIbtqgFaXKMTZu0xfU; Wed, 28 May 2025 19:30:10 +0000 X-Authority-Analysis: v=2.4 cv=DbzcqetW c=1 sm=1 tr=0 ts=68376442 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dt9VzEwgFbYA:10 a=ItBw4LHWJt0A:10 a=T_Alst9gAAAA:8 a=zstS-IiYAAAA:8 a=KfneG8_v_-bp4IyX6FgA:9 a=DvZ5ixILWSEuw56YIEpp:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3jSFtziZn3qTmUU3snViczkxxyMefiuleOqSrPsPOSU=; b=mAWzn0FQms/92FuGRX1kIau4JC AAcj+6PjcFTpMK/tiFYObVYK52mmyy2jX6GDrEEvvzq99GJI6R4RK0kH/XrU68XUjFufCQOVJX3LN eXX3MgElfSSZqwRxC0Qs+63sU; Received: from 97-118-46-156.hlrn.qwest.net ([97.118.46.156]:42420 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1uKMTZ-00000002gDr-0DHo; Wed, 28 May 2025 13:30:09 -0600 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 26/47] Windows gdb+gdbserver: Make current_event per-thread state In-Reply-To: <20250519132308.3553663-27-pedro@palves.net> (Pedro Alves's message of "Mon, 19 May 2025 14:22:47 +0100") References: <20250519132308.3553663-1-pedro@palves.net> <20250519132308.3553663-27-pedro@palves.net> X-Attribution: Tom Date: Wed, 28 May 2025 13:30:07 -0600 Message-ID: <87ldqgfs8w.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.46.156 X-Source-L: No X-Exim-ID: 1uKMTZ-00000002gDr-0DHo X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-46-156.hlrn.qwest.net (bapiya) [97.118.46.156]:42420 X-Source-Auth: tom+tromey.com X-Email-Count: 14 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfDjmK/DtDFIzum2WiQcE6rdFUlggt0iq/22MfXnDB7CHN+HCSS0MByDHSYrtPnVNMU5NU+hC2Rd0rnQcvHgYQu1deayYoNPfM2LpAZEn1aVSU+oBBoT5 Fm8Gv/TwJC4UijnDoKVCGxZmlXtSSa0qNAdcAC7l5g7F/a7xcr5ZLG4MqtnCNhyIcepUnzJB2ZKepBJtrpTr2QlHBrdQMQMVJlU= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Pedro" == Pedro Alves writes: Pedro> With non-stop mode, each thread is controlled independently of the Pedro> others, and each thread has its own independent reason for its last Pedro> stop. Pedro> Thus, any thread-specific state that is currently per-process must be Pedro> converted to per-thread state. Makes sense. Pedro> Since each thread will have its own copy of its last Windows debug Pedro> event, we no longer need the same information stored in struct Pedro> pending_stop. I had to go refresh my memory of what happened here, but I see a comment in gdb/nat/windows-nat.h: /* A vector of pending stops. Sometimes, Windows will report a stop on a thread that has been ostensibly suspended. We believe what happens here is that two threads hit a breakpoint simultaneously, and the Windows kernel queues the stop events. However, this can result in the strange effect of trying to single step thread A -- leaving all other threads suspended -- and then seeing a stop in thread B. To handle this scenario, we queue all such "pending" stops here, and then process them once the step has completed. See PR gdb/22992. */ So I think this makes sense as well. Thanks for doing this. Approved-By: Tom Tromey Tom