From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id U6NaIw8YOmhLBzsAWB0awg (envelope-from ) for ; Fri, 30 May 2025 16:41:51 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=wcYTfany; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7D2C81E102; Fri, 30 May 2025 16:41:51 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-8.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 215B91E0C2 for ; Fri, 30 May 2025 16:41:51 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B5D443858D29 for ; Fri, 30 May 2025 20:41:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B5D443858D29 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=wcYTfany Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id A74E53858D20 for ; Fri, 30 May 2025 20:41:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A74E53858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A74E53858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1748637679; cv=none; b=xA5MPVrCLzL4ln9/aq4Z515uGeZMxetq3c8g+4F62+COCJFWh71dJDyXvfa3/lb7x9Zh9FgMrWvuNLGt97fMs9ad6L4+wI7ItQStvlXs3B3XAMGQYCzu7MqMqXzvNxZtX7XfprZ+zC53d9rqRJZZwbFMXMjeQjvHsWvqfvW3VDA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1748637679; c=relaxed/simple; bh=9S6CYMvlulekJ7GhPGZcosvIZ5+GgnY93uMuqud5oPg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=QSjyL9fFPZJLpvoyeIEhqNXew3oLqc1c9a6MkXJa3OiiM5U0gBVuk8PTxewZOosdRJ7W8BdlWhF1Gihlrb5Kkkwda4ssbeqX9qpj+W3qI9ZTvz5isoNctWrW1cNzyPELlqICxbveTEEWyb0iJifjzyjDAXpyL1tM1SyzEsfbF2s= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A74E53858D20 Received: from eig-obgw-5003a.ext.cloudfilter.net ([10.0.29.159]) by cmsmtp with ESMTPS id KwzzuTSBvf1UXL6XWuu9MF; Fri, 30 May 2025 20:41:18 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id L6XVuPRvDrsgDL6XVuzjy2; Fri, 30 May 2025 20:41:17 +0000 X-Authority-Analysis: v=2.4 cv=TNGOSEla c=1 sm=1 tr=0 ts=683a17ed a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dt9VzEwgFbYA:10 a=ItBw4LHWJt0A:10 a=T_Alst9gAAAA:8 a=zstS-IiYAAAA:8 a=4gJCQxTY9lYAx0IQTDUA:9 a=DvZ5ixILWSEuw56YIEpp:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=cR6sJaKd+U1EsEP3mcDxeiSY+7x8+21LmEo+a6zq4Zs=; b=wcYTfany+QM1bZ2s7pBmzjp86j Vi7VDZfSBYhoo3+PaowPtnLSjuM3OvUhKYnyTbcY+r9E7CY+rKjE2N0jh/ntbYho608GUHYIvsEdD RoJgekyiMHeoG4DKeKjBUhHgz; Received: from 97-118-46-156.hlrn.qwest.net ([97.118.46.156]:41006 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1uL6XU-000000027kt-2ZND; Fri, 30 May 2025 14:41:16 -0600 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 20/47] Windows gdb+gdbserver: Elim desired_stop_thread_id / rework pending_stops In-Reply-To: <20250519132308.3553663-21-pedro@palves.net> (Pedro Alves's message of "Mon, 19 May 2025 14:22:41 +0100") References: <20250519132308.3553663-1-pedro@palves.net> <20250519132308.3553663-21-pedro@palves.net> X-Attribution: Tom Date: Fri, 30 May 2025 14:41:15 -0600 Message-ID: <87ldqd25n8.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.46.156 X-Source-L: No X-Exim-ID: 1uL6XU-000000027kt-2ZND X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-46-156.hlrn.qwest.net (bapiya) [97.118.46.156]:41006 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfIY89Z2ogj64kGs+fZu/cJ8GA7VNswLttlT2gUCTWsBSk54eGXFo3S5vEDHymVvqDBRWPvHF4HD26wsb+PmA7HiyEcuarJqXBZ/uUMrdOq5xDr57HiNf 6c54BAifDurgZVNcUCOQiFkXNu9+EdxGpGlY9iTBV9CwMSXaUc0wThRBHjPlrSmNd9RgMo2IrPeRD62jv3eWU0ekIKejhWA3chI= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Pedro" == Pedro Alves writes: Pedro> windows_process.desired_stop_thread_id doesn't work for non-stop, as Pedro> in that case every thread will have its own independent Pedro> WaitForDebugEvent event. Pedro> Instead, detect whether we have been reported a stop that was not Pedro> supposed to be reported by simply checking whether the thread that is Pedro> reporting the event is suspended. This is now easilly possible since Pedro> each thread's suspend state is kept in sync with whether infrun wants Pedro> the thread executing or not. Thanks, this makes sense to me. Pedro> I considered whether it would be possible to keep the pending_stop Pedro> handling code shared in gdb/nat/windows-nat.c, in this patch and Pedro> throughout the series, but I conclused that it isn't worth it, until Pedro> gdbserver is taught about async and non-stop as well. Makes sense as well. For future tasks like this, perhaps a bug report would be useful. Approved-By: Tom Tromey Tom