[PATCH 0/7] [gdb/testsuite] Fix TUI tests for freebsd

Tom de Vries
2025-07-18T13:02:28Z

I've been working on fixing the TUI tests on x86_64-freebsd.

I've submitted an earlier attempt here [1][2].

But after realizing that using TERM=ansiw would solve all problems, I started
over.

This series consists of the following patches:
1 [gdb/testsuite] Fix Cursor Horizontal Absolute clipping
2 [gdb/testsuite] Handle Horizontal Position Absolute in tuiterm
3 [gdb/testsuite] Log on return in Term::_log_cur
4 [gdb/testsuite] Handle auto_left_margin in tuiterm
5 [gdb/testsuite] Fix Term::_csi_m with no args
6 [gdb/testsuite] Use TERM=ansiw in tuiterm for bsd
7 [gdb/testsuite] Add Term::get_string_with_attrs in tuiterm

I've already submitted patch 1 and 2 separately [3].

Patches 2, 4, 5 and 6 contain necessary fixes.

Patch 1 is a tuiterm fix for a problem that I spotted while working on patch
2.

Patch 3 makes logging more robust, such that patch 4 doesn't break it.

Patch 7 adds a new tuiterm proc that I wrote while investigating the failures
fixed by patch 5, and applies it in the test-case I wrote it for.

The result is:
...
# of unexpected core files 1
# of expected passes 952
# of known failures 1
# of unresolved testcases 1
# of untested testcases 1
...

The core file and unresolved are due to PR33176, a tdep assertion failure.

The untested is due to failing to compile gdb.tui/tui-layout-asm-short-prog.S.

[1] https://sourceware.org/pipermail/gdb-patches/2025-June/218943.html
[2] https://sourceware.org/pipermail/gdb-patches/2025-June/219006.html
[3] https://sourceware.org/pipermail/gdb-patches/2025-July/219274.html

Tom de Vries (7):
[gdb/testsuite] Fix Cursor Horizontal Absolute clipping
[gdb/testsuite] Handle Horizontal Position Absolute in tuiterm
[gdb/testsuite] Log on return in Term::_log_cur
[gdb/testsuite] Handle auto_left_margin in tuiterm
[gdb/testsuite] Fix Term::_csi_m with no args
[gdb/testsuite] Use TERM=ansiw in tuiterm for bsd
[gdb/testsuite] Add Term::get_string_with_attrs in tuiterm

gdb/testsuite/gdb.tui/main-2.exp | 2 +-
gdb/testsuite/gdb.tui/tuiterm.exp | 46 ++++++++++++++-
gdb/testsuite/lib/tuiterm.exp | 94 +++++++++++++++++++++++++++----
3 files changed, 127 insertions(+), 15 deletions(-)

base-commit: f10173a01ffccbad7759ca24336355a87b0948aa
--
2.43.0