From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yVbOMAmeCWmPAh8AWB0awg (envelope-from ) for ; Tue, 04 Nov 2025 01:32:41 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=stackframe.org header.i=@stackframe.org header.a=rsa-sha256 header.s=duo-1634547266507-560c42ae header.b=MnRqhEmh; dkim=pass (2048-bit key; unprotected) header.d=outbound.mailhop.org header.i=@outbound.mailhop.org header.a=rsa-sha256 header.s=dkim-high header.b=rz0mP55j; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=stackframe.org header.i=@stackframe.org header.a=rsa-sha256 header.s=dkim1 header.b=SlYGvNhd; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C2A351E0BC; Tue, 04 Nov 2025 01:32:41 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2F9F31E057 for ; Tue, 04 Nov 2025 01:32:41 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AD3063857BAF for ; Tue, 4 Nov 2025 06:32:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AD3063857BAF Authentication-Results: sourceware.org; dkim=pass (1024-bit key, secure) header.d=stackframe.org header.i=@stackframe.org header.a=rsa-sha256 header.s=duo-1634547266507-560c42ae header.b=MnRqhEmh; dkim=pass (2048-bit key, unprotected) header.d=outbound.mailhop.org header.i=@outbound.mailhop.org header.a=rsa-sha256 header.s=dkim-high header.b=rz0mP55j; dkim=fail reason="signature verification failed" (2048-bit key, secure) header.d=stackframe.org header.i=@stackframe.org header.a=rsa-sha256 header.s=dkim1 header.b=SlYGvNhd Received: from snake.cherry.relay.mailchannels.net (snake.cherry.relay.mailchannels.net [23.83.223.171]) by sourceware.org (Postfix) with ESMTPS id 8D8863858CDA for ; Tue, 4 Nov 2025 06:31:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8D8863858CDA Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=stackframe.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=stackframe.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8D8863858CDA Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=23.83.223.171 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1762237880; cv=pass; b=UgBg8VyfzmYVdJTXtp/xHoxzzwmYJ70pYY6cIdXKE3h/NsDkuZTH2z9Dg4zm5W42UhHCqo+GXPxIMjFau4UNPDaujLcL8R6rB7rEPkvtrdUDs7WWtWN4cYjsl2T7HM2WvBg+49FvtBHknL6KeaoYdt7iz3bCsjAaNb2OvbQkEnw= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1762237880; c=relaxed/simple; bh=VtWaD5BiiZxO1TwxphN3d2NE3m5jf+U/xUcUdWroNOA=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:From:To:Subject:Date: Message-ID:MIME-Version; b=F9FyVZPeJo3/mZW/MojO/NugTAPAbRqggrV7Sop6DPezddKy5zODWGmkUXN9GFRQZlysRytFLF4G+eLvf8CFrg0hrZY4QAl30udWS/gnydigowPf7WbgZ4BLVNxbfrfCjyb4xndBDhX0wyzSegCyxIaUbn+nGMVZe13fG89WAZQ= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8D8863858CDA X-Sender-Id: _forwarded-from|130.180.31.158 Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 9B75F1618C5 for ; Tue, 04 Nov 2025 06:31:14 +0000 (UTC) Received: from outbound5d.eu.mailhop.org (trex-green-3.trex.outbound.svc.cluster.local [100.124.155.193]) (Authenticated sender: duocircle) by relay.mailchannels.net (Postfix) with ESMTPA id E1C7A161521 for ; Tue, 04 Nov 2025 06:31:13 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1762237874; a=rsa-sha256; cv=none; b=I/vtXQBs+itvNGPMOLKkFZhnmj8TOt1rK7yjhMVUFQqey5Jtkap43xTJH+P1NvlMCORc6/ EG7rKroTg2Gzqp5rEVhR6H5fa86QieO43UvU2B+2PQBA4Y/sRyEGokTDcrMwtZymM0bdJ6 NbTvDxcgkcTYjLKO1F6yDtH+ePtlBYL1BMc6tWDZLsWLqjTAtgom1kBxA/Ge2pEd9kq4Cc rd2Gl8U9jNOUdvDBgjE6GbvgRt3bHowwTs88YIBEtdybnCDFqgYukMDO8RAROU+FcRUKuO oXjwwnjPH+Yh+kCXcF2JE4byuGmWfR/GTfEil3Fq82UjmBkLoMk6MRCCJmZNWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1762237874; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AWtz8Wn9rCDCEEkiLBPgX8VnBzqOkEiBKTVUTJjfdNY=; b=aJw8VmhOclNCq9vXD8ryigMXeMi09aRsXOp/teXVK/3Hmh0vlsZF4D4rOtNO6v40VZfUMH fPzz3c+X+hNYxoNb1U3VWCpRCTyLnyJFR/tlTl23/y/Ir/j8xx2zgr6q9ol7hxTkzdWmF3 cjOPXWvK1YUywmRMDxHROVHhudHphgOlbNarF/eUa4f3gmV4RbMQmLB0jW1gO4IPVhf8Rd Piwfu8zujsjVwMUCEnOf2lmhbQ8xX1w0ZBJGM3dxF/Lxd/MXfiQ0qNXtAi4LCVGfNQWxY5 2FT5TFd6EZ2uSf6O1+22zlPnSYZwMrTNt20NqrGwz3eJUZMxhXktbX/Ku508vw== ARC-Authentication-Results: i=1; rspamd-77bb85d8d5-dk52x; auth=pass smtp.auth=duocircle smtp.mailfrom=svens@stackframe.org X-Sender-Id: _forwarded-from|130.180.31.158 X-MC-Relay: Forwarding X-MailChannels-SenderId: _forwarded-from|130.180.31.158 X-MailChannels-Auth-Id: duocircle X-Versed-Average: 6cc12ec965d895a7_1762237874390_1889246878 X-MC-Loop-Signature: 1762237874390:4144900589 X-MC-Ingress-Time: 1762237874390 Received: from outbound5d.eu.mailhop.org (outbound5d.eu.mailhop.org [3.121.156.226]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.124.155.193 (trex/7.1.3); Tue, 04 Nov 2025 06:31:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stackframe.org; s=duo-1634547266507-560c42ae; h=content-type:mime-version:message-id:date:references:in-reply-to:subject:cc: to:from:cfbl-address:cfbl-feedback-id:from; bh=AWtz8Wn9rCDCEEkiLBPgX8VnBzqOkEiBKTVUTJjfdNY=; b=MnRqhEmhaRKA5K0VJcz6toXECiM83JKIWuXLKwXniFqNWLlIMNWTPizWsBhj8FO0jaDjhys7Djhxa Hga7sEF/MGhjRYgy5SzY9OcJacwgBy66OauFucJTRahkmpUx3/5vXv+WHUkGD4MD/2gVEu+0V+/3hE SXaNfDedy6Jfom0M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-type:mime-version:message-id:date:references:in-reply-to:subject:cc: to:from:cfbl-address:cfbl-feedback-id:from; bh=AWtz8Wn9rCDCEEkiLBPgX8VnBzqOkEiBKTVUTJjfdNY=; b=rz0mP55jQNp31qMclUjvqj5Fmw7yDyQ2oj3BZOYiCBFAa8nNFlvb4JhkkCJp8IhhxifQjQnkiFmDi sL+jkL0ekusG0BfIuygq8Rz/HZEujBmEVDG2on3TZ/9m8nLQ7fkmKsOPBFFKULKRdN6cd4Nvs071j4 ijNTBATbfV26cqDJrK7/QcWwQXiL446KtWe26JIIfGOfstzmxZDdikSxXNyikk+lSI9CNKaeTLHCyc ACwi/Ru1CSmgw+Irqt5OSnpwalc5ALcpM0F4ioD0OjfMaVRYzwSEaCuOFcoUZRulXPnU+l0FoGK4Ps +3hQjSUD8TJAycIcxLW92+nkzkl0DxQ== X-Originating-IP: 130.180.31.158 X-MHO-RoutePath: dG9ta2lzdG5lcm51 X-MHO-User: d8a8dbc9-b947-11f0-b7ac-5f56af36decb X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Mail-Handler: DuoCircle Outbound SMTP CFBL-Feedback-ID: d8a8dbc9-b947-11f0-b7ac-5f56af36decb:9 CFBL-Address: prvs=0403dc4dd1=abuse@outbound.mailhop.org; report=arf Received: from mail.duncanthrax.net (mail.duncanthrax.net [130.180.31.158]) by outbound3.eu.mailhop.org (Halon) with ESMTPSA id d8a8dbc9-b947-11f0-b7ac-5f56af36decb; Tue, 04 Nov 2025 06:31:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=stackframe.org; s=dkim1; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=AWtz8Wn9rCDCEEkiLBPgX8VnBzqOkEiBKTVUTJjfdNY=; b=SlYGvNhdDARIQKKwkbSBNtnDp5 ntKALfarhS7PjxxP5nKCCb8rGJxnK8M1jXZ3Kvnt5PEuhurrL/sbR9Ao+UfV+/rmMQxkkjE3UITYH 830/WW7f34B2iZLlfOqteUEmAMDt4Y1pDvQkmMXHGV8geKBO5kim5zzzZTxC7pyYBRjsnS9GInGKw MRhtoIHnp1AVcLhla/Hn0Abd5NxGRlcTQdzjt7HRrIpnYX/12rpMRxXB/GYs2cduCVkhQQ8HDeDwN Fs9WYt7v02sp3nV2Arw6hVjnKz7UVWIho2Ba8niSELbXwafra9LR9AoFbvP+xRQBZGI7nTCcMrwL+ pkvrOEYg==; Received: from [134.3.93.166] (helo=debian.stackframe.org) by mail.duncanthrax.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97) (envelope-from ) id 1vGAZP-0000000352J-2btI; Tue, 04 Nov 2025 07:31:07 +0100 From: Sven Schnelle To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org, Helge Deller , John David Anglin , binutils@sourceware.org Subject: Re: [PATCH RESEND] gdb/hppa: guess g packet size In-Reply-To: <03732666-279b-4b21-a23f-165dd04fc99d@simark.ca> (Simon Marchi's message of "Mon, 3 Nov 2025 17:59:47 -0500") References: <20251101080538.857188-1-svens@stackframe.org> <87seeuak0z.fsf@tromey.com> <87tszapzhx.fsf@stackframe.org> <03732666-279b-4b21-a23f-165dd04fc99d@simark.ca> Date: Tue, 04 Nov 2025 07:31:06 +0100 Message-ID: <87ldkmpavp.fsf@stackframe.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon Marchi writes: > On 2025-11-03 16:39, Sven Schnelle wrote: >> Tom Tromey writes: >> >>>>>>>> "Sven" == Sven Schnelle writes: >>> >>> Sven> With qemu supporting 64 bit now, add some code to determine the >>> Sven> register size of a hppa remote target. >>> >>> Thanks for the patch. >>> >>> Sven> +struct target_desc *hppa_tdesc32; >>> Sven> +struct target_desc *hppa_tdesc64; >>> >>> These should be 'static'. They can also just be objects, not pointers, >>> I think. >> >>> Sven> + hppa_tdesc32 = allocate_target_description ().release (); >>> Sven> + set_tdesc_property (hppa_tdesc32, PROPERTY_GP32, ""); >>> Sven> + >>> Sven> + hppa_tdesc64 = allocate_target_description ().release (); >>> Sven> + set_tdesc_property (hppa_tdesc64, PROPERTY_GP64, ""); >>> >>> The reason I suggested using objects and not pointers is that, although >>> we do have a number of calls to .release() in gdb, we somewhat try to >>> avoid them. >> >> I might of course be wrong because i don't know the code well, but >> struct target_desc is declared in target-description.c and in the >> tdep file it's only used as opaque type. So it can't be used as object >> because the size isn't known. Is this correct, or am i misreading the >> code? > > It seems you're right. My suggestion would perhaps be to make the > global (well, static) objects of type `target_desc_up`, you won't need > the release then. Thanks. I just sent a v2.