From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id RbvCGjy/QmmLhAUAWB0awg (envelope-from ) for ; Wed, 17 Dec 2025 09:33:32 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=HtiDEGoO; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 58A691E08D; Wed, 17 Dec 2025 09:33:32 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B6F371E08D for ; Wed, 17 Dec 2025 09:33:31 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 3F7FC4BA2E23 for ; Wed, 17 Dec 2025 14:33:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3F7FC4BA2E23 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=HtiDEGoO Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 5CA674BA2E04 for ; Wed, 17 Dec 2025 14:33:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5CA674BA2E04 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5CA674BA2E04 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1765981982; cv=none; b=nyuXFs4AKNEK2Zr3kb3NGumpCPDu/CMlN2RctLzMKBde57S0OlzhKKT8X6aDSx2esv+C9zAJ/ToUYkpeREhXLy7P8jcdwwQZ3SSu8L/ya1YkbV7iuk/fnAKTjRPwyFTmfwW6Dh3WDDLfx3rrIb/vrL7anKPtZfoGwL5k/02xzZw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1765981982; c=relaxed/simple; bh=dwkLruVR+u3IEZw4d7k2xbcr3XzeyD+5CpqGw6ReKb8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=eCpuZwBlsQCgZEOuGGtXV3scbhpwP3h4kbIv10Px0HgwcHnOebnH89SD3NlpHyPjYiMpekId4xyYuw/Riep2lYP7KTRCxlcD+xKCyBb/DRBzYO1syiSKAC+rRcKkoYIrfeDp7kmFFGDh4JAiYRzk8Ta3IPiwFwEUP2/EVeYAkYU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5CA674BA2E04 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765981982; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tjmw+m58o5Rt8GQOkeq6IMgZbQXaL1KoanaaEsP+3cg=; b=HtiDEGoOB87JJ4mUlhmt32Zitu9XNg0i5yN5QpvuR3ptWbNgSO7WCAnOgvNwRcS5GtHBu0 eAFO65XrtL7ZMjYijDpI8XDxA/yrQXYKhwd56rN+0wd4m5hfn1aKY4udRoe8xsBIVKfRl1 Z+TsK0vHI8uz4O9oJkf+175iPaHFXRQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-121-nbdJ01q8Mfq3ibaF882n8A-1; Wed, 17 Dec 2025 09:33:00 -0500 X-MC-Unique: nbdJ01q8Mfq3ibaF882n8A-1 X-Mimecast-MFC-AGG-ID: nbdJ01q8Mfq3ibaF882n8A_1765981980 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4775e00b16fso40378935e9.2 for ; Wed, 17 Dec 2025 06:33:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765981980; x=1766586780; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tjmw+m58o5Rt8GQOkeq6IMgZbQXaL1KoanaaEsP+3cg=; b=bAj9HhAt4uRExH+vPyP8yizoGSfS8vRYGRof0wi6Xgw5+/OD9bHlRZvYvii7oR2Now jOUbllKvc/N87RxT9Qqp1HCmR8Xxss3krbJX5r3Chqhke/wZ7g0ozGaEI6Tv4cSknFmO V1WQH+pyypdQayBOpOgdHRArwpgSXRnMtopew4vR2hY/yoneEmjAKd+IiTylldAG/cB+ p0FdMSlx18SaxS89gH6s25CAmYTFS4aITTBHhHZfpKGwch8W1eiOnzK86/hTcW9yxBik r1E5EpOi7e20nk9WOLkHLjZHtF/FmCcfZJ7IE7+H+8ySrKRS4WAXhKrXkSx+mQxCBTK+ W3vA== X-Gm-Message-State: AOJu0YylcUgCdTL4HbdRO2reqwOIXEztz6fkDoXfmEtDT8WnRJNSzRmJ QWBMhQvu1H3iz1cwUEdwFbyFRlBw+8rP7cp3Fceb6QniF5CahrnXGOAU7k4DIxfxKbaP0qHi8Xe eEk6iHAOg9I40WRiILLXQZEdaLIfd/hkTZtMD/grrhGlDl7afofuDE6gGKr5Nt4g= X-Gm-Gg: AY/fxX6H+j6m9yPVZOFHOap0sybh2czPkgwFfB7XFzBu1x1N3G+odoUvVrmxZO9y9MF jkMz1viFOBNFBo3MthUz85u4HenkSZlKhqR/GCH6rKNABZTO5bzflAyQhscSIDWlJrRVWZtM5LU MOSjAXK8NNOzE8UA7kE1VHap1ZibwYuOIwgrwv/AdsrnQ/78JwZnfQ2pIQBtfmP604Nn2iXGXs3 nTtqhM5dj7pypSKFsU13drYyV6zQ4F3TQFaU/zJwKEhmopCIoDTOLUD2nHbUrU+3LRwF+wwGzjb FVuxHyBH/0UYrUARhyo+izKCKRdFaInXvWY5kp+mV9nKkcjKVILRsx3vzLad8SZmcGFYVT2L/L6 aLGLB X-Received: by 2002:a05:600c:6219:b0:477:b734:8c22 with SMTP id 5b1f17b1804b1-47a8f8ab86cmr179242575e9.8.1765981979652; Wed, 17 Dec 2025 06:32:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IG1+6RAx3USNoPdeAG1I725PaI6NTLKu9UcfI8tnr/dcUeE6QhB6r3vFyO4zARjhUoh3FiSyQ== X-Received: by 2002:a05:600c:6219:b0:477:b734:8c22 with SMTP id 5b1f17b1804b1-47a8f8ab86cmr179241985e9.8.1765981978704; Wed, 17 Dec 2025 06:32:58 -0800 (PST) Received: from localhost ([31.111.84.207]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47bdc1d20absm43943425e9.4.2025.12.17.06.32.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 06:32:58 -0800 (PST) From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv3 1/7] gdb: improve line number lookup around inline functions In-Reply-To: <87qzuo9e9c.fsf@tromey.com> References: <87qzuo9e9c.fsf@tromey.com> Date: Wed, 17 Dec 2025 14:32:57 +0000 Message-ID: <87ldj141ra.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: feFQ6n0BxZZ3A5gIrhmHslNelZDPlf3Uk2EbbAMmZ0g_1765981980 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess writes: > > Andrew> So my proposal is that the backward scan of the line table looking for > Andrew> an is-stmt entry should not be performed when NOTCURRENT is true. In > Andrew> the case above this means we will report the entry at index 9, which > Andrew> is for line 10, which is correct. > > Thanks for the explanation. It all made sense to me. > > Andrew> + if ![runto foo] { > > We're bracing if conditions these days. > > Otherwise this looks good to me. > > Approved-By: Tom Tromey I fixed the TCL bracing issue and pushed just this patch for now. I'm taking a deeper look at some of the questions you raised on the later patches. Thanks, Andrew