From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 321QBUvnhGn/HCoAWB0awg (envelope-from ) for ; Thu, 05 Feb 2026 13:54:03 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=FBAH2cMq; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0274B1E08D; Thu, 05 Feb 2026 13:54:03 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED,RDNS_NONE autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (unknown [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 62B921E08D for ; Thu, 05 Feb 2026 13:54:02 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id D38114B920EB for ; Thu, 5 Feb 2026 18:54:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D38114B920EB Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=FBAH2cMq Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id F27174B9DB7C for ; Thu, 5 Feb 2026 18:53:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F27174B9DB7C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F27174B9DB7C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770317616; cv=none; b=cfvlWu0skYLdFAGbNITukyLdvIURpTI5NbVt5V0pKrwsWLfyorkOdDow5ld75XSNdJUYipLC/7yDyHJ1fDl9WppEOdJ5wTf6OM+JCqDOefgnjIJOkJTlP7+mpPOSOxjrMC/9Hutpm/hOdVtUEsPJ0DYX4rmkujKr9OwY8imISCk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770317616; c=relaxed/simple; bh=mqioCxqnu90S5E4G9E8v+boM/kM41cMPYg2ZtiGC9Yc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=J++2IhQYctT+PARl8jGx+hcio4oCtHNZCBIZWkKEiWjlCk+pkexmHfySHKz+XamgKUPleRCI7l7lJPiAgyPkAKVzyrograPr0Gxq2SsDGMvUhpCy4V74yWMuJ0Ak2CuB/EfvXlpH930iIiM3y49zvu6KsFTH8WcBK2iGYrsmncY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F27174B9DB7C Received: from eig-obgw-5003b.ext.cloudfilter.net ([10.0.29.155]) by cmsmtp with ESMTPS id nztrvsytpKXDJo4TvvWpEE; Thu, 05 Feb 2026 18:53:35 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id o4TvvBFtr2l0ko4TvvZRE3; Thu, 05 Feb 2026 18:53:35 +0000 X-Authority-Analysis: v=2.4 cv=UfRRSLSN c=1 sm=1 tr=0 ts=6984e72f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=HzLeVaNsDn8A:10 a=ItBw4LHWJt0A:10 a=7d_E57ReAAAA:8 a=zstS-IiYAAAA:8 a=gZTFc7JnXhYdJ5liqz0A:9 a=jhqOcbufqs7Y1TYCrUUU:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=iBqHS67aTNI178FF1Yq8MI/w1oMNgD8Roc7BHtEal1A=; b=FBAH2cMqgWS5ifYneg5qAxc8M8 Pjsf07y6emHAxpBCBh9B/BisvtEDgWd94ZMCi/UbYiYPUzZpXC8HdShib2DPlfohDwiM2q+fAhRRQ TPahAkpNK1XJLRjtPTeFr1KiM; Received: from 97-118-49-200.hlrn.qwest.net ([97.118.49.200]:46538 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vo4Tu-00000002y63-3Au3; Thu, 05 Feb 2026 11:53:34 -0700 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/dwarf2: don't search included symtabs recursively In-Reply-To: <20260203173640.215967-1-simon.marchi@efficios.com> (Simon Marchi's message of "Tue, 3 Feb 2026 12:36:27 -0500") References: <20260130025546.322629-3-simon.marchi@polymtl.ca> <20260203173640.215967-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Thu, 05 Feb 2026 11:53:33 -0700 Message-ID: <87ldh758eq.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.49.200 X-Source-L: No X-Exim-ID: 1vo4Tu-00000002y63-3Au3 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-49-200.hlrn.qwest.net (bapiya) [97.118.49.200]:46538 X-Source-Auth: tom+tromey.com X-Email-Count: 11 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfBCEyGvDdsfTu9AxiQRv1uV24INL0eQAN/w4RYIvYwUK/Y7B9VQxiCvlg/MgQCOjJQnm1P87JTiGehEylkqiSiN7ED7sToB6F009edNfK4q0nzJaW0FD ZuRIz3emtxFXeZIrwl5I6L2xxNTdwLxiNMLSutagdSdN6swvjB/hvWpaNZvgVeGdy2PXF5a3wlE3w9nHdqJ1etdvtoo27w5Hk/0= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> It therefore seems unnecessary to do a recursive search, in Simon> recursively_find_pc_sect_compunit_symtab, it will search some symtabs Simon> multiple times. Agreed, thanks for finding this. We discussed this elsewhere but probably what we eventually want is a mechanism to avoid searching included symtabs more than once across an entire search. Simon> I am not sure how blockvectors work exactly, whether the blockvector of Simon> the includer CU is a superset of the blockvectors of the includees. I Simon> ask that because it seems like in practice, the requested PC always Simon> seems to be found in the first searched CU. I haven't investigated this Simon> point more than that though. I think each compunit_symtab gets a blockvector that describes exactly the functions defined locally in that CU. It would be very unusual for a partial unit to really contain code. The reason for this is that the normal reason to make a partial unit is to share common things between CUs, but two CUs would not normally describe the same function with the same address ranges. It wouldn't be invalid to do this, just not very useful. Approved-By: Tom Tromey Tom