From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Sep2JH34k2nfbT4AWB0awg (envelope-from ) for ; Tue, 17 Feb 2026 00:11:25 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=VH44OE01; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8EA821E089; Tue, 17 Feb 2026 00:11:25 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EB8231E089 for ; Tue, 17 Feb 2026 00:11:24 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 1AC7E4BAD17A for ; Tue, 17 Feb 2026 05:11:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1AC7E4BAD17A Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=VH44OE01 Received: from mail-dl1-x1232.google.com (mail-dl1-x1232.google.com [IPv6:2607:f8b0:4864:20::1232]) by sourceware.org (Postfix) with ESMTPS id 3B5854BAD16B for ; Tue, 17 Feb 2026 05:10:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3B5854BAD16B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3B5854BAD16B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1232 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771305059; cv=none; b=I/nn/a45ThO3B8o7LI0iYrQgKxzi6C4hz1zBivMVh/ScanZFm6ajquwPqqyrg1dEAWJ1CUaiwhQLca41jBs4ZCO2th0S5oxhwCWr+u7L+1mHNnULb3nSwbxOOs14zPYDbx1SCqjCye1lZqDC4zO20QUmC/IXDZYj9kYuDLkPNx8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771305059; c=relaxed/simple; bh=upPb5yb+Zn0LiOcM8lBNdFcCfUM0ErNL1W1PJCnzF3o=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=GF/MaFVuDCOZWyf9sEGvSCLNmhVjgC7Gak1kSLmIQ4gt4Ic5f+xdXhDbR4HHiKiFe83B2YZC3LREe1VWbQMv1X6TSHSI5inRw39nWjpPpsKf4eB8HLYDKIDi6orQPNcrq3XKncdVo32C1U+n+h+r2isTvvHfqVyAxwTEdNikTWA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3B5854BAD16B Received: by mail-dl1-x1232.google.com with SMTP id a92af1059eb24-1270ac5d3efso3472858c88.1 for ; Mon, 16 Feb 2026 21:10:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1771305058; x=1771909858; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=A+1uPxk8HWilgzPnpvfvcoHnnGqt9HeomU5G55ZZzEY=; b=VH44OE01OYSO/D4PUTZsdcp+XjQhpwQQOytrz/X+3+SXTOq5KthZBO9x6n/icP4NFO nQU6gqzFP9Hr99yegXF29jpXR59Y4qV2vOiqjGUT9MLGwfVn5+lMORNoYKDAB1corA10 wXS0Y0mt3JwGQI6R0b9ZuHkuqJxBiL/UgO/4vo4FquB3PdDLYo4N8zrHvAiC2nWIykEJ R3YpBBBZbDk2S6siE8GpGNG9PYxjCy3bXfW8XtLH5U+sYNewwo85GOua9RjAPdB6SvNF Gpt4o1CPrumEAnjclP9Uxk5oLkR/oysmpr7gBiGL8eI9OlKbcsz35mOXLogT1wTBy7lL F9ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771305058; x=1771909858; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=A+1uPxk8HWilgzPnpvfvcoHnnGqt9HeomU5G55ZZzEY=; b=tyE9mFPwAUf+Fbm7DdQ5ubeprTu3q9eUt/DqbfavGePgv60mZKxh/ai+Rq8fTyGSAV tDt1VvsMZ5erZur+YvsfYdMqevAAI2iei9EJtsZj37+tqKaoZ8ETo4aQHCyduW8xtpyy WV1cLtyhkSjriaFSjl69zAytrzfgND2ZSMYZIvIpd3Q5/hBkFpkfZoa8JCn1fI/BnIVI K0SQzdknDG+v59opcbn88mUWQdZCATA3Kh8hz+K8wkU+pOVw/xqCbzMAod9YJ0Rb2aJy p34NW61V9SxHzuuNEj5sSGMOnAzvHHpoGGtaHDIyjayllXqIdOrzpnBJVuaiMn6pxbLV S6Og== X-Gm-Message-State: AOJu0Yx4HYQwcYqyid6UByulsDsXzrMz6hbGusdb2owjR2ueOlNueK3P NmXbiHLnzMFxmzgr1G/rk7VZBvg6+1grubJAjM8nkNb6qa7lTmV7dk7BPG3VnAY7vmU= X-Gm-Gg: AZuq6aLXiwznwIr2iC2Gp51HomT8z3mpAcEuWqAkBr3S6pdp0WsWOtOqJcW+x7pVLrI 5wBuekbVJsT850rPg6AUWM8GjUhdguBF+MM/Sr/2CmYrFV/fVk4LLGX3V7k9p3q22HGXXOLMuVF iwzdzaBzBPbaxJdJPo1xwatiDY7Dcee6SSXkqQkDA2DLk4v4siMAEOQbh8aZ3MZV3OuJMf0l44O C8ZY6WarVMLsAXwfKk+fPVf/dBapnW0GeRw+bMdVDa2mx4mctj6NELXBF+oh1rSRO3HPPNuce39 Jo7FGLp/QvxWECwbjymhoikSWuSIKo+D4PQN8zzj5tqlSzqb2E6lZfGvBXMGfaWEYiXrSm3YWKl 11Zs3G7Q3qBGv9yxWkK9ZcJtllWL2CUp/IX9vcqiiNxW8mvVgLOk/czFZOTwn+B3IupAs4iIXJL H2DJrdawHY7zemDzvrgp9rKdb0FlKVoyDx2g== X-Received: by 2002:a05:7022:1583:b0:11a:e610:ee32 with SMTP id a92af1059eb24-12741bb8398mr3651748c88.25.1771305058063; Mon, 16 Feb 2026 21:10:58 -0800 (PST) Received: from localhost ([2804:14d:7e39:8083:f04c:42e3:5943:38f6]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12742cc83e6sm13424245c88.15.2026.02.16.21.10.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 21:10:57 -0800 (PST) From: Thiago Jung Bauermann To: Simon Marchi Cc: gdb-patches@sourceware.org, Chris Packham , Luis , Tom Tromey Subject: Re: [PATCH v2 1/2] GDB: aarch64-linux: Reorganize gdb/arch/aarch64-gcs-linux.h In-Reply-To: <5cebfbfa-a192-4359-97d9-83455d40fdc6@simark.ca> (Simon Marchi's message of "Sat, 14 Feb 2026 09:29:10 -0500") References: <20260214045504.361392-1-thiago.bauermann@linaro.org> <20260214045504.361392-2-thiago.bauermann@linaro.org> <5cebfbfa-a192-4359-97d9-83455d40fdc6@simark.ca> User-Agent: mu4e 1.12.15; emacs 30.2 Date: Tue, 17 Feb 2026 02:10:55 -0300 Message-ID: <87ldgsx8dc.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon Marchi writes: >> diff --git a/gdb/aarch64-linux-nat.c b/gdb/aarch64-linux-nat.c >> index 028de981588b..b2dd192a7b56 100644 >> --- a/gdb/aarch64-linux-nat.c >> +++ b/gdb/aarch64-linux-nat.c >> @@ -51,7 +51,7 @@ >> #include "gdb_proc_service.h" >> #include "arch-utils.h" >> >> -#include "arch/aarch64-gcs-linux.h" >> +#include "arch/aarch64-linux.h" >> #include "arch/aarch64-mte-linux.h" >> >> #include "nat/aarch64-mte-linux-ptrace.h" >> @@ -1013,7 +1013,7 @@ aarch64_linux_nat_target::read_description () >> active or not. */ >> features.vq = aarch64_sve_get_vq (tid); >> features.pauth = hwcap & AARCH64_HWCAP_PACA; >> - features.gcs = features.gcs_linux = hwcap & HWCAP_GCS; > > This one could stay HWCAP_GCS, but I don't have a preference. Luis prefers keeping it as HWCAP_GCS (and also renaming AARCH64_HWCAP_PACA to HWCAP_PACA), so that's what I'm doing for v3. > If we want to ensure / prove they are the same, we could add asserts > like this in the nat/ header: > > static_assert (AARCH64_HWCAP_GCS == HWCAP_GCS); > > That assert would only be checked when compiling natively for an aarch64 > system (where HWCAP_GCS is available), but it's better than nothing. I mentioned this concern mostly for completeness, TBH. IMO it's not worth adding this assert unless we're actually bitten by this problem (which AFAIK hasn't happened yet). -- Thiago