From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MXmIBXhWnGmjMQcAWB0awg (envelope-from ) for ; Mon, 23 Feb 2026 08:30:32 -0500 Received: by simark.ca (Postfix, from userid 112) id 10CFB1E0BA; Mon, 23 Feb 2026 08:30:32 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E37311E089 for ; Mon, 23 Feb 2026 08:30:30 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 5C9E14B9DB65 for ; Mon, 23 Feb 2026 13:30:30 +0000 (GMT) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 5E39E4BA23FD for ; Mon, 23 Feb 2026 13:30:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5E39E4BA23FD Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5E39E4BA23FD Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771853418; cv=none; b=LquXrBI9sKD+9tUldd9iUPzRbFJClOZbMCtcED5ObdRG+jiIU9VvXqz/xf+CXvMExeEcY5Rqx8ZgO/vc9PCXXXPkE6bhUa1XeBSEmy+1iWf7HJK0YkH77HfEULpb0/Dd0zx4S5Ik+OqyjwaEjCswJDO7I2JiZK8pvplJef9wYqQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771853418; c=relaxed/simple; bh=8LOi+7e4Zxj5hVfZmTerHRHMFy+NPe8oJ9cBGfNx1Uk=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=odx+ygOqn2AI9tWiFzKobZyahtLZc4mnGKfmzNSS7kJLDJJVTNkCKE0ntx+HGAAr+X0LN963rQV3DPe96BmL9kGfXX45kFOO3UjDLUsIbknxSiGs0anULgPaFrlxKaH2kiyHMB1Hm4b8XsrqEgGKXp9PP8isQ2au4O7gBNWJrRc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5E39E4BA23FD Received: from mop.sam.mop (2.8.3.0.0.0.0.0.0.0.0.0.0.0.0.0.a.5.c.d.c.d.9.1.0.b.8.0.1.0.0.2.ip6.arpa [IPv6:2001:8b0:19dc:dc5a::382]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sam) by smtp.gentoo.org (Postfix) with ESMTPSA id 26F3A34360A; Mon, 23 Feb 2026 13:30:08 +0000 (UTC) From: Sam James To: Tom Tromey Cc: gdb-patches@sourceware.org, Eli Zaretskii Subject: Re: [PATCH v3 0/8] Correctly handle inline functions with dwz In-Reply-To: <20260220-dw-inline-fixup-pr-symtab-30728-2-v3-0-98ae8ab28fab@tromey.com> Organization: Gentoo References: <20260220-dw-inline-fixup-pr-symtab-30728-2-v3-0-98ae8ab28fab@tromey.com> User-Agent: mu4e 1.12.15; emacs 31.0.50 Date: Mon, 23 Feb 2026 13:30:04 +0000 Message-ID: <87ldgjmvtv.fsf@gentoo.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org --=-=-= Content-Type: text/plain Tom Tromey writes: > The new indexer does not correctly handle inline functions when 'dwz' > is used to compress the DWARF. This series fixes the bug, cleaning up > a number of other things on the way. > > I've separately regression tested each patch in this series on x86-64 > Fedora 41. I've also regression tested the series as a whole with the > dwz, gdb-index, and debug-names boards. > > Even with that I messed up somehow, so v1 didn't actually fix the bug > in question. I must have modified the patches after testing..? > > Anyway in v2 I've moved the line recording the CU inclusion and added > a comment explaining the placement. I re-ran the aformentioned tests > and didn't touch anything. With this, I get a crash when creating an index: ``` $ /usr/bin/gdb --batch -nx -iex set\ auto-load\ no -iex set\ debuginfod\ enabled\ off -ex file\ \'/var/tmp/portage/dev-debug/gdb-9999/image/usr/bin/gdb\' -ex save\ gdb-index\ -dwarf-5\ \'/var/tmp/portage/dev-debug/gdb-9999/image/usr/bin\' dwarf2/index-write.c:818: internal-error: build: Assertion `offset_inserted' failed. A problem internal to GDB has been detected, further debugging may prove unreliable. ----- Backtrace ----- 0x561db97db67e ??? 0x561db9fd8a04 ??? 0x561dba59b487 ??? 0x561db9918fe0 ??? 0x561db991fb47 ??? 0x561db9927e99 ??? 0x561db99282e0 ??? 0x561db9f12f56 ??? 0x561db9b6612c ??? 0x561db9b6cbfb ??? 0x561db9644baf ??? 0x7f8b51c03649 ??? 0x7f8b51c03765 ??? 0x561db96648d0 ??? 0xffffffffffffffff ??? --------------------- dwarf2/index-write.c:818: internal-error: build: Assertion `offset_inserted' failed. A problem internal to GDB has been detected, further debugging may prove unreliable. Quit this debugging session? (y or n) [answered Y; input not from terminal] This is a bug, please report it. For instructions, see: . dwarf2/index-write.c:818: internal-error: build: Assertion `offset_inserted' failed. A problem internal to GDB has been detected, further debugging may prove unreliable. Create a core file of GDB? (y or n) [answered Y; input not from terminal] ``` --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEBBAEWCgCpFiEEJaa7iN2bdkxrVUHCc4QJ9SDfkZAFAmmcVlwbFIAAAAAABAAO bWFudTIsMi41KzEuMTIsMiwyXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25z Lm9wZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQyNUE2QkI4OEREOUI3NjRDNkI1NTQx QzI3Mzg0MDlGNTIwREY5MTkwDxxzYW1AZ2VudG9vLm9yZwAKCRBzhAn1IN+RkNdb AQDTtYcP9dGnqtNH33woUR+6Srude+x+r7CkXafdH1IsjgEA5+BOWoy9Dndl2vgY MQSz9xGAFBtgb4zlt96Ig5lvzAE= =L6Tr -----END PGP SIGNATURE----- --=-=-=--