From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8YnGI4Cvp2mzbxMAWB0awg (envelope-from ) for ; Tue, 03 Mar 2026 23:05:20 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=sczZCr4e; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8C84C1E0DD; Tue, 03 Mar 2026 23:05:20 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D1B631E08D for ; Tue, 03 Mar 2026 23:05:19 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 76CC54BA2E1B for ; Wed, 4 Mar 2026 04:05:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 76CC54BA2E1B Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=sczZCr4e Received: from mail-dl1-x1234.google.com (mail-dl1-x1234.google.com [IPv6:2607:f8b0:4864:20::1234]) by sourceware.org (Postfix) with ESMTPS id 91C554BA2E0F for ; Wed, 4 Mar 2026 04:04:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 91C554BA2E0F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 91C554BA2E0F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1234 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772597092; cv=none; b=EKIEaV2R3IGOlq9QWrmoyzR9YmWoZ5IIzVeZOwx9zV1nzfoos0+5D1hAKba8yw3IBdxzMOea+TDiU8aoo+kyRkw0+DnCn37UuPp1fDF+tMDYPq6FScM3x8GaAIKhrijL1Pkfzc5BC/2hYYDnsOY18TL8sYmzDtfwlMmMReZFp1s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772597092; c=relaxed/simple; bh=uudJCWP6kWpY4/vNqFppzRZqzT5w9yc3hOvl12V6sjs=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Oe24Vyfxr6OUodNaDPjIKIErTHLKagl3a7P695xzakIJYtx0qLz9kyQhE4bgw/+MfxeOkoZCbK3vd+3ey8rcwckbBj+j9Beb4baTgD7UcF48tCwWMzRs5b/Dpla/l7c5p0iw/I689igksdMwAPSJfarp2o9/PBwhu2fLBe2XDLg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 91C554BA2E0F Received: by mail-dl1-x1234.google.com with SMTP id a92af1059eb24-126ea4b77adso8320867c88.1 for ; Tue, 03 Mar 2026 20:04:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772597091; x=1773201891; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=DJBNscbE4WvVC96mz6uJ6zE0skT+mFXaIGQpkxCOXc0=; b=sczZCr4eIsaKCRJeUN8gs75acRkOwKY4G+45tq0PF0mhhU8D+5t3PuS7pgz8+XwRxl VNfFWZd3oJGc36OG+41s7+5Y06oUaE7aDZis+lzmAbmDPQge2YNs3b7/4cX3id3mdW9v cBTMYdOHh79OY6suBtDRvTN15MFtIpTrFVuLIApqr1cuL4bBbqI+i8l8LLreLfVI7Igf XtrsHNHb4ay2mQnTHD2+K4kAefwZ2R31S6QdvX+YkVlAXvAH166q8T+wap1UrR+O3zrz eFlaBbadoz9Eg6XStKxD0LhsAF7utqBYrDobNlgiotqgXh8e28nPFJC1xVvbBZT2VYmy CcOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772597091; x=1773201891; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=DJBNscbE4WvVC96mz6uJ6zE0skT+mFXaIGQpkxCOXc0=; b=M9U9grtKMjdDTINWSZQtY7tNY56kh+YKv0/nyDtXLlXMpKaMvEJG9CP8yKXu3oGO6R Y3ZUvKdfhjDeyHX3Y0NZQP8OhUqcsc86t0AzT6g0auLiduAlK7IvyCd2DGvLatM8MCym /FG9T/GC5BeD4ngdZ6ir8/Eltv1XATemwKyjJZywwDCeO8VEuP+z/vd9wEIYeMRf4fJ9 t4Xi69H809UebpQzZJ9AkdJ+Koh4DkDaGozWFu0cr3d0f9Wgl+qDpbED7JnWMwbUvisg 39wQEU/6kAl3QoEHgvuyWcgFkzoBgNDX+lgK/wXN1Toxmewah6MnaSHo9m9922KZtLID S1vg== X-Gm-Message-State: AOJu0Yx5FtbudFeSKtsjK2018kMYhUm9MCDv+MPbbd3hRBSCjYuhwLR7 N+MjIJdubZ5de9Q09vkQMd/K2TOYmSvn7HdYSum8Dj40vFObwSZeH9sAyzQn+2k7vE8= X-Gm-Gg: ATEYQzyQ6RMSSRPLQWIqRFSQjZnkhgI+djkAu01vTMkUEpwOHeAb42cf9x+QBHUranq INxIGq9WmPF4O/lw4AdSFJEyYxZcp+Pcd6VURxkVqU7drFj4XIv3tiu+b6Af5ih/2cAmoaDFuG4 9CTTn8hB5/upQYPtGiheZvBo+Ucp5TpEvrZWAqpnWojARCCRWKBRZtCX7d0dYcaeSxccWBl3p+l 27vu5xUJiDa/B1vJ76B3URvDcMWnMLaTFc3uDYNNVUem3aWzG98yJBjMy0i84nUb3v5wT+8U9cb 9RFp0mYCGVdfsp43dc/gurFPRo1GW/P98BFcXYP2+nuifsmZrEj/zVkvmF+lOmE0xNQiuFBlOLW s46e8egZphE6xCX/xBxC24v7LuQ90La1qdNkeaS01zIOY/qX1JJjp+NQOFE7YOpQgvZORsGknbK xWgj+502tSh1jCdm8xlfBnep+avfp/oe9l5PDRlziSgJl2 X-Received: by 2002:a05:7022:78d:b0:11a:273c:dd98 with SMTP id a92af1059eb24-128b70975b0mr237012c88.20.1772597091435; Tue, 03 Mar 2026 20:04:51 -0800 (PST) Received: from localhost ([2804:14d:7e39:8083:f04c:42e3:5943:38f6]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-127899dfc47sm21451641c88.6.2026.03.03.20.04.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 20:04:51 -0800 (PST) From: Thiago Jung Bauermann To: Simon Marchi Cc: gdb-patches@sourceware.org, Chris Packham , Luis , Tom Tromey , sunilkumar.dora@windriver.com Subject: Re: [PATCH v4 1/6] GDB: Add aarch64-pauth-linux.h to gdb/arch/ and gdb/nat/ In-Reply-To: <8e20892a-b4ed-47c1-90bc-69d8d948aafa@simark.ca> (Simon Marchi's message of "Tue, 3 Mar 2026 10:51:28 -0500") References: <20260303050641.198127-1-thiago.bauermann@linaro.org> <20260303050641.198127-2-thiago.bauermann@linaro.org> <8e20892a-b4ed-47c1-90bc-69d8d948aafa@simark.ca> User-Agent: mu4e 1.12.15; emacs 30.2 Date: Wed, 04 Mar 2026 01:04:49 -0300 Message-ID: <87ldg8ck9q.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon Marchi writes: >> diff --git a/gdbserver/linux-aarch64-low.cc b/gdbserver/linux-aarch64-low.cc >> index b19e605f55d6..07ddfb324466 100644 >> --- a/gdbserver/linux-aarch64-low.cc >> +++ b/gdbserver/linux-aarch64-low.cc >> @@ -22,6 +22,7 @@ >> #include "linux-low.h" >> #include "nat/aarch64-linux.h" >> #include "nat/aarch64-linux-hw-point.h" >> +#include "nat/aarch64-pauth-linux.h" >> #include "arch/aarch64-insn.h" >> #include "linux-aarch32-low.h" >> #include "elf/common.h" >> @@ -41,6 +42,7 @@ >> #include "arch/aarch64.h" >> #include "arch/aarch64-gcs-linux.h" >> #include "arch/aarch64-mte-linux.h" >> +#include "arch/aarch64-pauth-linux.h" >> #include "arch/aarch64-scalable-linux.h" >> #include "linux-aarch32-tdesc.h" >> #include "linux-aarch64-tdesc.h" >> @@ -952,7 +954,7 @@ aarch64_adjust_register_sets (const struct aarch64_features &features) >> break; >> case NT_ARM_PAC_MASK: >> if (features.pauth) >> - regset->size = AARCH64_PAUTH_REGS_SIZE; >> + regset->size = AARCH64_LINUX_SIZEOF_PAUTH; > > It's not a deal-breaker for this patch series, but I'm just wondering: > is there some "native" thing, provided by Linux, that could give us the > size here, like sizeof(some_type)? If we're trying to use the native > stuff in the native files, then for consistency it would be nice to > avoid relying on our own definition of the sizeof pauth. There's struct user_pac_mask in so we could do sizeof (user_pac_mask), but to allow using older system headers that would require a configure test as done in patch 6 of this series, and add our own definition of the struct in case the system headers don't have it. I can do that as a separate patch if you think it's better. -- Thiago