From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MsxhKeRiCGqevT8AWB0awg (envelope-from ) for ; Sat, 16 May 2026 08:28:20 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=XrJDlPt+; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 971FA1E0B1; Sat, 16 May 2026 08:28:20 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AE5691E093 for ; Sat, 16 May 2026 08:28:19 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E08684BAE7C8 for ; Sat, 16 May 2026 12:28:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E08684BAE7C8 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=XrJDlPt+ Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 35CCC4BABF35 for ; Sat, 16 May 2026 12:27:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 35CCC4BABF35 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 35CCC4BABF35 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778934472; cv=none; b=JZF2x59JoCLyvzMKgNfR+MjY28W2HJ10iBYvDx/jT3rc9ARGGMSWP3xrPswS7PNm44ztLliZkbqtQUSyW3eoQYxbUKyo2Bnoa3+wSodzsOpBX6jC/Lp18RuSi2HrYsT9q/lde7gfvfa1CSUA5DBbZ8Lk/QGEeL5Zjts1K+R+RYI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778934472; c=relaxed/simple; bh=KWAXx/ir0LRutyTW0o46JjF6XKSrOsmtf0V05+teKjY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=kLHgaJgvG91ReCxuWNGCNV8KXyMV9baKujeW51tfGT2aBPlBDx9YZVVtnHHs1PnxQ2u/8Io8zWEh6TFIKsCYKKOer+AmZ1namu0UP9DFAFn+4Z4cuB0TBUJ0DC28+LuBOAro+xnvsL3VUbHo5QDLRCyg/ba8M3aAlTmfjY0Q1kA= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=XrJDlPt+ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 35CCC4BABF35 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778934471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zGQJC42DnZvaFnTAuQVqJ68ZTo+xdPfmy/37PeeDOMg=; b=XrJDlPt+hH0f4NCM8hdCrACIjPRmJlRtMbx84nKQaTUyR6eSAGY1k51amXQdjIkpW6nt7K 7LtD1QD1X7qlPAwk88PaAThBTA7mb5Q7tvP7doOjSEQl4iRSxmj2nSmsOLd3opeukWb1LJ srIf9driTzGsjs3jy4FTboUdFSYb+os= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-82-rHVOkJM4P52H9AGARfIIPQ-1; Sat, 16 May 2026 08:27:50 -0400 X-MC-Unique: rHVOkJM4P52H9AGARfIIPQ-1 X-Mimecast-MFC-AGG-ID: rHVOkJM4P52H9AGARfIIPQ_1778934469 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-48fd8162ed7so4342405e9.2 for ; Sat, 16 May 2026 05:27:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778934469; x=1779539269; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zGQJC42DnZvaFnTAuQVqJ68ZTo+xdPfmy/37PeeDOMg=; b=tNbMpaO9SHban8GGOJQy0Z6T9SnJG7wQWq1QJ1hBeONilI95JkYUqa9o/bBc4saAQy zG0zUxfucWK5pvcUzPzPxXLHWAiPenF5YKqEGoatb2kRhBtXekma59OkhmJ5nW96sc6F yVMFb+tj+llRpOi40I6r+gGRCPvGGCITwqQXbmQf2jN1W/lOswdptF7rbrGbl7pTsgXF Dioy0KQ8Ts3Bme63PpmeedPL+w977wHIGutgdytUHG89keMSVwcWOOHBVr0Q4S+4Fhuk 3atStkPPvi805gHv2SqcjzVbJOqjhI+EnU3+nZOeJ7DYpqJKv4QVmQu39rFiAz+uOYNk 63Bw== X-Gm-Message-State: AOJu0YwnF4hwiRNtuCP9pbUaSFZEIZcBsBNGWjE9ICO3HrqbWRZ9nLnd DzVhOELV/P6Utaf6DEKEvTNh5RcJifQpQjT7WPL3F5fD0NR9KaC8IV9t8vaNZJv/hOWo79nu/WB yiGKPQf03Y7SkV0ovC0Wq9LZeOTn4jGMG/u4meRgIpljNILPFD2vq7mYidZO0dM7apdOF8iM= X-Gm-Gg: Acq92OGHBOwlPm4MkJGC/duQFJDnWwC/QYWwOI8WoMCN6djDEDz8CuNwHscFXG5aY0g z4xVmIRdQq4XkTO19zkfHGXYXnxDJQf/FauNy7XbipLgdOzL3ep+grYlmOE9yikiZgGGgcQvnmN xdGVSh9pHfZO+any3NK4x1P63GFccbXV2VmhehQxSG61Hb1KNy+fiz2aUBkj4NtuuXEdl0Lq7hG lLWRqMXkJpe3sc3HvN4voIRwq9VSTeBMGnv5eq0QIh9HY0P65VAvL7zZqQOwWLOn+7RvhI6HoQJ AB0TWJ6AiLPgUjj/vA4SPgGB3SjMT2+FPn3qDi80Dae838i496UDQHkrzc4s7AVBXEq158pSppP o6qz28lfPLerlqWNpQA== X-Received: by 2002:a05:600c:c4a1:b0:48a:5363:8cac with SMTP id 5b1f17b1804b1-48fe63268eemr110624205e9.22.1778934469268; Sat, 16 May 2026 05:27:49 -0700 (PDT) X-Received: by 2002:a05:600c:c4a1:b0:48a:5363:8cac with SMTP id 5b1f17b1804b1-48fe63268eemr110623575e9.22.1778934468778; Sat, 16 May 2026 05:27:48 -0700 (PDT) Received: from localhost ([109.144.20.165]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe57943b2sm128451955e9.8.2026.05.16.05.27.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 May 2026 05:27:48 -0700 (PDT) From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] gdb/python: add type traits check for all PyObject sub-classes In-Reply-To: <87tss8ha3h.fsf@tromey.com> References: <491de87828ea40daa77a485da4e14e476e0c7a1d.1778839043.git.aburgess@redhat.com> <87tss8ha3h.fsf@tromey.com> Date: Sat, 16 May 2026 13:27:42 +0100 Message-ID: <87lddjczep.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: G_RMCXTsWk_trLzubGD5J7tPOeetajV40U8cXAdhkMY_1778934469 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess writes: > > Andrew> The problem is that Python is written in C, and PyObject_New doesn't > Andrew> call any constructors for `some_new_type`, nor for any of the fields > Andrew> within `some_new_type`. > > Since working on the Python safety series, I have been wondering if we > could remedy this. That is, give gdb's classes constructors and > destructors and arrange for these to be called in-place in tp_init / > whatever the destroy one is. > > This way we could use idiomatic gdb code, which would be safer. > > I was planning to investigate this more deeply once Matthew Longo's work > was done, since I didn't want to touch all the type objects and cause > conflicts. > > Andrew> + > Andrew> +template > Andrew> +struct is_python_allocatable { > Andrew> + static constexpr bool value = > Andrew> + std::is_trivially_destructible_v && > Andrew> + std::is_trivially_copyable_v; > > Brace and operator placement. Fixed. Thanks. > > Otherwise this looks good to me. > > If the tp_init experiment works out I suppose we may end up reverting > this. But IMO it's best not to wait on something that might not > happen. ACK. If/when you have a better solution I'm happy for this series, at least the static_assert bits and the associated test, to be removed. This was really just me trying to find a way to "test" the fix that is in patch #2. If we can come up with a solution that means we can use C++ objects and the constructos/destructors "just work" then I'm 100% in favour. For now though, I've gone ahead and pushed this series. Thanks, Andrew > > Approved-By: Tom Tromey > > Tom