From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id UU5pEYm5GWq1OycAWB0awg (envelope-from ) for ; Fri, 29 May 2026 12:06:33 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=aky+A65/; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 42E211E062; Fri, 29 May 2026 12:06:33 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C1ECA1E062 for ; Fri, 29 May 2026 12:06:32 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 43B554BA23DA for ; Fri, 29 May 2026 16:06:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 43B554BA23DA Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=aky+A65/ Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 50A214BAD171 for ; Fri, 29 May 2026 16:04:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 50A214BAD171 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 50A214BAD171 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780070698; cv=none; b=qV4yNesyDUFYkg5AZ/bdIHVR3VMqWkmKhq7Lv1klhUsgeLvo3JP1Bz6+ijJsKrWQDrzzeh5LVYk3BQWembOA3/UbhWjB5DZFSuquhBZ6oVuzHITMB5ugpFN6A13im1CHXsR/tZ4A1t5J/4H7INuTC3Eaa6kCHU+QnwbnsuR+x20= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780070698; c=relaxed/simple; bh=C3rvLkPI1QmlT9qgfCajWJVMh2zVII8791zfrRPU6ag=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=rO/C5Za9cOIQeSJnivBawzL4GgHAqsyJbP7tGlHrt8XULaOD7mEda4yX6LLeqYBUeNFEeFWpzQI2DGI7HmTLUHrmKK2VZaj1pUAlHVToN1khViifiKDCDFx/SlVSxP6pPrzblJBUgZlLyoJ+95zBHDkfkX+KvdHxFrFHomb/C9I= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=aky+A65/ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 50A214BAD171 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780070696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=imQTbeA4a16suqb/XEbzMgXEVaj60CKz8u4UHZuR9Rw=; b=aky+A65/aZoIr41hXjMAh+kGmUbJWhk2pdeQ9VZm/Tewh9BF8Pc3SxYuZYQi32QrLGzLZL J8fikJ0PJJYl9Um0xbV5M+8MS7nZEdWkX4hau1hXOfL9G9aBqKe1y7x8o5o2LdC49IRxNI r7RHQDIcI07hPg59DjkVsiWIDGkUjL4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-607-TWEQz48SN4aFnD_IQwADHA-1; Fri, 29 May 2026 12:04:54 -0400 X-MC-Unique: TWEQz48SN4aFnD_IQwADHA-1 X-Mimecast-MFC-AGG-ID: TWEQz48SN4aFnD_IQwADHA_1780070694 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-49058295985so42366975e9.2 for ; Fri, 29 May 2026 09:04:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780070693; x=1780675493; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=imQTbeA4a16suqb/XEbzMgXEVaj60CKz8u4UHZuR9Rw=; b=jsd45f3XDT1hCagg6aN3Js+1njzN4AB1KNrBXLnMLsun6kLy8ds1DaIpjOYIAAPoZH 4eRF4dX3XFGCf1o8R82Qx1R4TG5zWrEOqXiiv7z42qstHv4zBP5VBGlPniWfowUd/ZJR C9ijA4mskXtNZ4la67NJklFk15tITTgIKIzhQhaMpZ4KyfgP2WFleK9kpSk8BWjZwdC4 zsarb13MXQri++DSW67k0phNl0MOhWjZr+cZ7pWjeYhZENAjYDQ+m1e3668xe5wR2jNR 4su95zx5Yl220RHzg3Gz5u8Sf+4CJIbMkYWhcAFGQgeixSVQARnurF5ZBHl84ztE/Voa tsOQ== X-Forwarded-Encrypted: i=1; AFNElJ8lBlNZw9wEptyBeW9K0mMyQYWNiYEDwKQ+U4m0gVUA6yXnKvcrIDoKon8zuPsjyIcYb5jD+UVRZKsHNA==@sourceware.org X-Gm-Message-State: AOJu0Yx+9zs9lB6tdKjH5kLhlkTMgOOBSn6lozLAxBcvTEwA3a6PBgm4 lbf0exjaFLDhPeLiqUJZ2q+mRnG3YJOld97E8+xSy21+FhJEl9+SXysJXT++LrEp95yGNN6wNOy NicYUAxvfZD/q8JN0VuAjh4imiGeE32P3LQkTJ98IAwNYs1g7Fk30bGGxPMCYt079gCGI9F8= X-Gm-Gg: Acq92OHmKxAEWIiwLs7tMLJtCGOqCdjpvFqk+edoQNChiZmCryY0Of70NszzcBhN7HB Ib8JFUITAeJLdVa341d5TK/E9q7pJTEYTn9DjEuWsnkSrEh1ES+JBVJwnDidlg/mGZc7gs8ni0V YfKwjIf1KOOU7163UAXkROFENzIMdUD5obo0wVpNoCdtYbIq3GtcKGzzTv/vyOoVwxsXEtzaG3h 2ZbscqGPEsNtpCoCVLHgtYZ4Kb8Qjhby65rJUDYxoh6HKgieQtPf90mcLRF43epIuqD8hAgWGFg n3pLqRO+eFDbAWgzR6szt9ZdQpS9MRllIq67hC0cDohqQJOBitI/53sjU1K5R2HisWHRdsbaKD3 CcD2kTHApT39vTXkGef3AIqH6Dg== X-Received: by 2002:a05:600c:6592:b0:490:a1dc:e542 with SMTP id 5b1f17b1804b1-490a2904ab0mr5702785e9.6.1780070693569; Fri, 29 May 2026 09:04:53 -0700 (PDT) X-Received: by 2002:a05:600c:6592:b0:490:a1dc:e542 with SMTP id 5b1f17b1804b1-490a2904ab0mr5702235e9.6.1780070693065; Fri, 29 May 2026 09:04:53 -0700 (PDT) Received: from localhost ([213.31.44.43]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4909cab0e79sm101185125e9.13.2026.05.29.09.04.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2026 09:04:52 -0700 (PDT) From: Andrew Burgess To: Tom Tromey , gdb-patches@sourceware.org Cc: Tom Tromey Subject: Re: [PATCH] Use gdb::Requires in gdb::ref_ptr In-Reply-To: <20260521174527.2962256-1-tromey@adacore.com> References: <20260521174527.2962256-1-tromey@adacore.com> Date: Fri, 29 May 2026 17:04:50 +0100 Message-ID: <87ldd2xkv1.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: a3W0ouU3qzkjcERsF-DpusQX3Q29pNN6mV3immLTA_0_1780070694 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom Tromey writes: > Andrew pointed out that the use of is_convertible in gdb::ref_ptr is > incorrect, and that it should instead check the value. This can > easily be done using gdb::Requires. Thanks for putting this patch together. LGTM. Approved-By: Andrew Burgess Thanks, Andrew > --- > gdbsupport/gdb_ref_ptr.h | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/gdbsupport/gdb_ref_ptr.h b/gdbsupport/gdb_ref_ptr.h > index 0eb654324c6..757c3f395ba 100644 > --- a/gdbsupport/gdb_ref_ptr.h > +++ b/gdbsupport/gdb_ref_ptr.h > @@ -21,6 +21,7 @@ > #define GDBSUPPORT_GDB_REF_PTR_H > > #include > +#include "gdbsupport/traits.h" > > namespace gdb > { > @@ -76,7 +77,7 @@ class ref_ptr > > /* Copy another instance. */ > template - typename = std::is_convertible> > + typename = gdb::Requires>> > ref_ptr (const ref_ptr &other) > : m_obj (other.m_obj) > { > @@ -93,7 +94,7 @@ class ref_ptr > > /* Transfer ownership from OTHER. */ > template - typename = std::is_convertible> > + typename = gdb::Requires>> > ref_ptr (ref_ptr &&other) noexcept > : m_obj (other.m_obj) > { > @@ -115,7 +116,7 @@ class ref_ptr > > /* Copy another instance. */ > template - typename = std::is_convertible> > + typename = gdb::Requires>> > ref_ptr &operator= (const ref_ptr &other) > { > /* Note that self-assignment is not checked here, as it isn't > @@ -141,7 +142,7 @@ class ref_ptr > > /* Transfer ownership from OTHER. */ > template - typename = std::is_convertible> > + typename = gdb::Requires>> > ref_ptr &operator= (ref_ptr &&other) > { > /* Note that self-assignment is not checked here, as it isn't > > base-commit: ea27a7ae9048367bde15246b248f856803efc674 > -- > 2.54.0