From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id /ZafNcnzdWqxIhEAWB0awg (envelope-from ) for ; Fri, 07 Aug 2026 11:03:37 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=X6tnR7JJ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id CB3941E09B; Fri, 07 Aug 2026 11:03:37 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 566241E09B for ; Fri, 07 Aug 2026 11:03:37 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C76A04B9DB53 for ; Fri, 7 Aug 2026 15:03:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C76A04B9DB53 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=X6tnR7JJ Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 38BE54BA901A for ; Fri, 7 Aug 2026 15:03:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 38BE54BA901A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 38BE54BA901A Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786114993; cv=none; b=ZL6oPzv7JMBbF6GNxvwPie9p+bHC2xUaqF+EorC1v3eiIRbj6AejTUNhnV3BhyfitXqzG2ETF9DTUW5Sn6MxGhiHo19d4WPWL1/8S4GUJdmMN5aQqPrJDzbl8+5jEkRs8HUBtgIllApdXOKa44ZvlBpJSxp8/T764a4748xq93U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786114993; c=relaxed/simple; bh=fW7qoyeAlz8bTHKPoXia5CtcqYk2WG7UEJx/9b3jOHo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=HRHpZ86nvinnEsuamTgpzgSxmgegx/9zTd1mywrqHsBm9iOh3hK3EoTkC0b2K/TJU5Io/boLZH7r7v2aqrfJtvFjpTa7sXsSI1mPJdhVeZ2cLj2KdQNb0C3dSmZwCN7o5t1fZzVmBhB/sQmUFcrBM2+i8OHYZHtagGEP7qIoCQo= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=X6tnR7JJ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 38BE54BA901A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786114992; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G3NYcSV4WaxGfb5ppjS1IQ8BvOlks8COXDXWV731aMI=; b=X6tnR7JJetSkUSBVuwwf4ALM5NbfGWTWC8XvkIt02TduV2xUWFk1xQLVe0XzP58dkiMHiZ d3MTs/1YkN77t53YBHZYmRH6MsQxp1jSIM1pq7kFDzdGYz1pQcMZ8fi4EXuyZ2LB4cRC29 6FMA/4jSWVG9HX790Y4hpmgxHRwuDFk= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-516-L_fmNQ7CO5CwmSoKIbD17Q-1; Fri, 07 Aug 2026 11:03:11 -0400 X-MC-Unique: L_fmNQ7CO5CwmSoKIbD17Q-1 X-Mimecast-MFC-AGG-ID: L_fmNQ7CO5CwmSoKIbD17Q_1786114990 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4954a93c565so18966295e9.2 for ; Fri, 07 Aug 2026 08:03:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786114990; x=1786719790; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=G3NYcSV4WaxGfb5ppjS1IQ8BvOlks8COXDXWV731aMI=; b=WXPilYhX+lxZsUO3Y954GlzGU+MtMunI69H+58k/uJ6U3y+OCUnPQeDM0T9uNovLLO 4L3o7W2GynOnfX2bjTcvhIU0jJKwDa1nZRMqcHtf6J/R9TTvqbXBSGtmVhtXAR6YfAWW GS6GrNuqdPKREADAh+Cov7dHl1N2oBuL38438s3lHpjXZjwKRy3Pqt9etn3LWWCfUKDk 6YABwBSfjE62UYR4X2gRQjaH8RnuwxGB/KVK8Y07/pInfKigr5SPeOoRvMp9r3tqtjAA AYZ6vG+M7MEx9Ql8Kg6eit7EKFgVU7/lDIbMmZ7K096vjtOINN/IeDa1GF14GGSY1hjx 2N1w== X-Forwarded-Encrypted: i=1; AHgh+Rq5TmnV4PeN/asE9bw9GfohLP9kjwRiQcOXx2fgIujRL4+kdDgKmRovX41Ae0hPAoZB5xtf9lT4jCLxYw==@sourceware.org X-Gm-Message-State: AOJu0Yy8RwWNO8GSCQ+/P8ccfwh5K9lAADI3eNaU1DWW3A/4G/ZyEVuI s7GoqZ0JNRaZWSoxZRwACI5ROlQ1fqt5PcylGdpRxBna7PNLPUx83NM0cYFeqyAXZrzi08bW3tW rcMLvprQkzjXTtkPIy+VgdWi3gSBNldmZwLSb0CJKCZ+VMs+is83gSfkqUZKUSvoxHNh5nck= X-Gm-Gg: AR+sD10Gy/zM6IpHO2+HJsI5D54+2GVGTA04dBu33v5AhvvZqWYN14odDzdZBcMFCvI JfCNHE0oWE4aae0/HWyO7S84ez+7hsbkaNZ34AB/6B8svLU23xI+jTF4s+0COjrTZAiPmF1DTMb C3PsU5Eivv/n4lXVkDe69X9yCfhN0eZlAZY2Jv+SylmnfXxnfuzdjtkznWVZ1xelvG+Td2duoSz mXnmzhvPVHq11hkkC3HdvUHlrsrgIC28QNEsGJjGPmiTTnqozVl7Z+tupEMkOHIlqWzj40oKeok pIZ4f0K60g9QZPHkOKFWq0wtcOY/z+FOHpdIbqe9U5dQrumh0SBfLqEFpSS8SKN7ecL/fJTVNwN cjFG9QoK2Vi8TBFhzVotaF7z/ X-Received: by 2002:a05:600c:1c21:b0:493:e460:1f6 with SMTP id 5b1f17b1804b1-4994e6fe377mr309194095e9.0.1786114990088; Fri, 07 Aug 2026 08:03:10 -0700 (PDT) X-Received: by 2002:a05:600c:1c21:b0:493:e460:1f6 with SMTP id 5b1f17b1804b1-4994e6fe377mr309192545e9.0.1786114989498; Fri, 07 Aug 2026 08:03:09 -0700 (PDT) Received: from localhost (227.114.208.46.dyn.plus.net. [46.208.114.227]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4995e9f9424sm39265645e9.8.2026.08.07.08.03.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 08:03:09 -0700 (PDT) From: Andrew Burgess To: Tom Tromey Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Always fetch Ada "main" name from the executable In-Reply-To: <87tsp6xcfo.fsf@tromey.com> References: <20260730170336.2547536-1-tromey@adacore.com> <87qzkclcm8.fsf@redhat.com> <87tsp6xcfo.fsf@tromey.com> Date: Fri, 07 Aug 2026 16:03:08 +0100 Message-ID: <87ldaikm6r.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: PR40JRs3GrnelrwS2sl4luyaa6JrS9XynoSqCNMAPv4_1786114990 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess writes: > > Andrew> gdb/ada: avoid rereading stale main name data in edge case > > Andrew> diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c > Andrew> index 906c5cd3465..174e04af04c 100644 > Andrew> --- a/gdb/ada-lang.c > Andrew> +++ b/gdb/ada-lang.c > Andrew> @@ -806,8 +806,7 @@ ada_main_name () > Andrew> sections) > Andrew> == TARGET_XFER_OK) > Andrew> && xferred > 0 > Andrew> - && (strnlen ((char *) main_program_name, sizeof (main_program_name)) > Andrew> - < sizeof (main_program_name))) > Andrew> + && (strnlen ((char *) main_program_name, xferred) < xferred)) > Andrew> return (char *) main_program_name; > Andrew> } > > Looks good to me. > > I suppose xferred < sizeof (main_program_name) and so the first strnlen I did think about this, but the section_table_xfer_memory_partial call is capped at 'sizeof (main_program_name)' so this check would really be an assert. But as the section_table_xfer_memory_partial call is part of this same `if` condition we'd have to split the code like: if (section_table_xfer_memory_partial (....) == TARGET_XFER_OK) { gdb_assert (xferred < sizeof (main_program_name)); if (xferred > 0 && strnlen ((char *) main_program_name, xferred) < xferred) return (char *) main_program_name; } And the extra complexity didn't seem worth it. > is probably now redundant. However this doesn't really matter, the main > name is not examined very often. > > Approved-By: Tom Tromey I've pushed the patch now. Thanks, Andrew