From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8jiSJSgl1mrCSDIAWB0awg (envelope-from ) for ; Mon, 19 Oct 2026 10:11:52 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=QH9wHc1V; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 62E971E050; Mon, 19 Oct 2026 10:11:52 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C917B1E04E for ; Mon, 19 Oct 2026 10:11:51 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2CD3B4BA2E2F for ; Mon, 19 Oct 2026 14:11:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2CD3B4BA2E2F Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=QH9wHc1V Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 021BB4BA2E27 for ; Mon, 19 Oct 2026 14:11:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 021BB4BA2E27 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 021BB4BA2E27 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792419082; cv=none; b=PRNKILVhBgElhDeTqrD+zWdJBLVTMJjgssBQko+Lbtw2hByGUQ04Vmoek17YDN68zW19GFcz52NvFq7WUXzCP5tv9ALIQWmCh9vxEsGxdvmUX+GcFYgRZxqhjdUA+QxccUx8QKcKocu0SwsPl1bnN8Ql6KpCSlcvhgGg5A3PKA4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792419082; c=relaxed/simple; bh=lgpFI16QC3G5QgL8HWTVR63zDL6wip/mibjxKdaqTEY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=CJNa5CS9LLnN/EVkZVnuOwCNkBLY0EcmBQacrbeLT7K7liKeihXD/LvvVMhruXQSRWx3gERI0PA7rB+DT4EEg12C4fwjtmlPsGksUJmNE2j7P3BOlxFgm6xikWjQytfKa4PXFjt0b32yd+fVyn6R1xA/AIoSE4J2NRIgtrdDtMQ= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=QH9wHc1V DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 021BB4BA2E27 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792419081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=diC0OHdH0GVz60G9DsYFPYvSoIYT2Jl0mo6uwZ8I7mw=; b=QH9wHc1VlX5BGy46+tLB60SAPhyHXzlta4fWR3nWb3GqEfLN766XYBDexKC5mJKi/nXxS9 xoMAripsi145sEPO9WV3j+XZ9BlopvSYTlm4N6v3Ek0fiWxl2sd8rr9bixKmt47KCD+1p6 t9CoegUgo/7TvbdSbYaAW1uri3tZJBE= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-249-EQHTGB4fPGK2oqB4OpVvyA-1; Mon, 19 Oct 2026 14:11:20 +0000 X-MC-Unique: EQHTGB4fPGK2oqB4OpVvyA-1 X-Mimecast-MFC-AGG-ID: EQHTGB4fPGK2oqB4OpVvyA_1792419079 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4a1bfd5516bso22025285e9.3 for ; Mon, 19 Oct 2026 07:11:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792419079; x=1793023879; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=diC0OHdH0GVz60G9DsYFPYvSoIYT2Jl0mo6uwZ8I7mw=; b=MFeuAJIdF0qsXXFKxpgpqjJiBWo994qbPIHAPthmBwKPO7HxozVKf9FsG/TWTWgBlZ F2UeC7cJHbEBDstu1ApRUuOqwnsn+FL8dHGKYH6u5N1BVMGnfqmfZYAocF0LcHrFX7rA L6aDghVmbJQkBpAvoZVvCSXVNiThwr0wVt/VuKVqyz4YNIZMB4IDjmp1oMWgN9P/IZTf Fp12ZJCKRLNkVvJ8TKwoFRv8fYh8Rm1fj2olmbaCiqLP7iT/Sp3D/0qn2XmU06LgGm0w KCmwU7fOnScqTbykXFDEjMXNnZpHqhmBvIwDBtGM0hZc9trUAIzVankeG3AgBY0CsFAc FiEA== X-Forwarded-Encrypted: i=1; AKwUvByfoz4am9KuXeRzyphRbYyQhPJOn7QIDpJsZP45Q1igZeNQ5BRhPz8NUofWMKp9qYq5T+N28W8UOOeb/A==@sourceware.org X-Gm-Message-State: AFq9FYJoQtb8LBNFtfR4g5O04minJMZGok3WSuZcVpHX0p3JzATvVG24 /415zf/byJTOq9mrZa1OtcqXdiPgfPG1x8iCjCFxuOezI6Pzv8ICl8JG1k6OmPRiheN1THBt8hm oFFpi9pIL3bs5MvJ4+8QTmxBDFnDXANOG/7BW16+VnSUauYAKMnzfjeL6hfL3axOa8bSOlvQ= X-Gm-Gg: AYBFou39KUdNSpbLoV8J4uefhmkIjnEHYYtg9WvraYSNes20GKxAELjKtZNaKqJU8mV lgBP6as31YLjmzM65wg4ElrRz53cTVrmc39/CBxvZpynzIa1X1liaEgIoPO2R3ijTflUK6ALbrF Z993vccfcFNBpCo+YDLNrVbAxv3iGL5mYbq8OOOU938lcWoTvykf2v3KnhQRgzRU9roDTq7THOV nmj3LD3tajZ/AUdBjmjIKUZg9qlbIsAYEAtQECPVQLGpw17Jk9DI4TkenlDXmFCj3VIH6HBYSI4 vUiyxuKpLb08569mAQnEyKRh8UGVcGVtLhm7uTg4qo1J7eSItVFjuMTj13QCzVMpR1dN X-Received: by 2002:a05:600c:154b:b0:4a1:e284:21a with SMTP id 5b1f17b1804b1-4a1e284038bmr108128705e9.24.1792419079036; Mon, 19 Oct 2026 07:11:19 -0700 (PDT) X-Received: by 2002:a05:600c:154b:b0:4a1:e284:21a with SMTP id 5b1f17b1804b1-4a1e284038bmr108127725e9.24.1792419078492; Mon, 19 Oct 2026 07:11:18 -0700 (PDT) Received: from localhost ([213.31.44.29]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a1d30d778bsm269287755e9.9.2026.10.19.07.11.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2026 07:11:17 -0700 (PDT) From: Andrew Burgess To: Guinevere Larsen , gdb-patches@sourceware.org Cc: Guinevere Larsen Subject: Re: [PATCH v2] gdb/record-full: fix stop status when inferior isn't resumed In-Reply-To: <20261009143916.47983-1-guinevere@redhat.com> References: <20261009143916.47983-1-guinevere@redhat.com> Date: Mon, 19 Oct 2026 15:11:16 +0100 Message-ID: <87ld7t93wb.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: JnDvk7rmKnunfvjr4f0FHGqjlNMwtJ7FPK80NrmYLKk_1792419079 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Guinevere Larsen writes: > The wait function for the record-full target has a check for whether > or not the inferior should be resumed. However, when we correctly > identified that it shouldn't be resumed, we incorrectly set the exit > status as "ignore", as though the inferior had resumed and had an > uninteresting stop. > > This would cause a problem when - for example - GDB has to wait for > all threads to actually be stopped, because we do that by waiting > until all threads have a wait status of "no_resumed", and the "ignore" > status would make us iterate over them and wait more. > > This commit fixes that by setting the status correctly to > not_resumed. The commit does not include a test because almost nothing > works with multi-threaded programs, and my upcoming series will > exercise this code path plenty of times, when testing it makes more > sense. Thanks for updating the commit message. One tiny nit... > @@ -1187,8 +1187,8 @@ record_full_wait_1 (struct target_ops *ops, > { > gdb_assert ((options & TARGET_WNOHANG) != 0); > > - /* No interesting event. */ > - status->set_ignore (); > + /* No thread was reusmed at all. */ Typo: reusmed -> resumed With that fixed: Approved-By: Andrew Burgess Thanks, Andrew