From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5429 invoked by alias); 10 May 2003 21:30:24 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5289 invoked from network); 10 May 2003 21:30:20 -0000 Received: from unknown (HELO esperi.demon.co.uk) (194.222.138.8) by sources.redhat.com with SMTP; 10 May 2003 21:30:20 -0000 Received: from esperi.demon.co.uk (1000@amaterasu.srvr.nix [192.168.1.14]) by esperi.demon.co.uk (8.12.9/8.12.8) with ESMTP id h4AL81bw012036; Sat, 10 May 2003 22:08:01 +0100 Received: (from nix@localhost) by esperi.demon.co.uk (8.12.9/8.12.8/Submit) id h4AL7wTQ008428; Sat, 10 May 2003 22:07:58 +0100 To: Christian Joensson Cc: gdb-patches@sources.redhat.com Subject: Re: build/955: build failure with GDB-5.3: sparc-nat.c structure redefinition errors with sparc64-linux, glibc-2.2.x References: <20030427150800.19859.qmail@sources.redhat.com> <20030427153321.GA3394@nevyn.them.org> <20030510095712.A19164@u1sparc.j-son.org> <20030510153527.A5854@u1sparc.j-son.org> X-Emacs: because editing your files should be a traumatic experience. From: Nix Date: Sat, 10 May 2003 21:30:00 -0000 In-Reply-To: <20030510153527.A5854@u1sparc.j-son.org> Message-ID: <87k7cy5x3l.fsf@amaterasu.srvr.nix> User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Portable Code) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-SW-Source: 2003-05/txt/msg00171.txt.bz2 On Sat, 10 May 2003, Christian Joensson muttered drunkenly: > On Sat, May 10, 2003 at 09:57:12AM +0200, Christian Joensson wrote: >> On Sun, Apr 27, 2003 at 11:33:21AM -0400, Daniel Jacobowitz wrote: >> > On Sun, Apr 27, 2003 at 03:08:00PM -0000, Nix wrote: >> > > The following reply was made to PR build/955; it has been noted by GNATS. >> > > >> > > From: Nix >> > > To: Christian =?iso-8859-1?q?J=F6nsson?= >> > > Cc: , , >> > > , >> > > Subject: Re: build/955: build failure with GDB-5.3: sparc-nat.c structure redefinition errors with sparc64-linux, glibc-2.2.x >> > > Date: 27 Apr 2003 15:45:01 +0100 >> > > >> > > On Sun, 27 Apr 2003, Christian Jönsson spake: >> > > > http://sources.redhat.com/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&databas >> > > > e=gdb&pr=955 >> > > > >> > > > Is *anything* happening on this issue in gdb cvs HEAD? >> > > >> > > My apologies for not following up; this patch, abstracted from Debian >> > > (where fading memory tells me it is due to Daniel Jacobowitz), fixes it, >> > > but is probably too ugly to go in; the incompatibility test should >> > > really be done by configure: >> > >> > Right on the origin and ugliness counts, which is why I never got >> > around to doing anything about it. But it's better than nothing, since >> > it lets sparc-linux build, so I suppose it should go in... does anyone object? >> > >> > > Index: gdb/gdb/sparc-nat.c >> > > =================================================================== >> > > RCS file: /cvs/src/src/gdb/sparc-nat.c,v >> > > retrieving revision 1.13.12.1 >> > > diff -u -r1.13.12.1 sparc-nat.c >> > > --- gdb/gdb/sparc-nat.c 3 Dec 2002 22:35:49 -0000 1.13.12.1 >> > > +++ gdb/gdb/sparc-nat.c 27 Apr 2003 14:39:53 -0000 >> > > @@ -33,6 +33,13 @@ >> > > #include >> > > #include >> > > #ifdef __linux__ >> > > +/* Sadly, conflicts with on Linux. And >> > > + -D_GNU_SOURCE brings in implicitly with . >> > > + Hack around this. */ >> > > +#undef FPU_REGS_TYPE >> > > +#define fpu asm_reg_fpu >> > > +#define fq asm_reg_fq >> > > +#define fpq asm_reg_fpq >> > > #include >> > > #else >> > > #include >> > > >> > > >> > > -- >> > > `It is an unfortunate coincidence that the date locarchive.h was >> > > written (in hex) matches Ritchie's birthday (in octal).' >> > > -- Roland McGrath on the libc-alpha list >> > > >> > >> > -- >> > Daniel Jacobowitz >> > MontaVista Software Debian GNU/Linux Developer >> >> ping... how's it going? >> > > I just thougt I'd test your suggested patch... it still fails... > > This is how the compile stops with error in the current gdb cvs HEAD: > > gcc -c -g -O2 -I. -I/home/chj/src/gdb -I/home/chj/src/gdb/config -DLOCALEDIR="\"/usr/local/gcc-binutils/share/locale\"" -DHAVE_CONFIG_H -I/home/chj/src/gdb/../include/opcode -I/home/chj/src/gdb/../readline/.. -I../bfd -I/home/chj/src/gdb/../bfd -I/home/chj/src/gdb/../include -I../intl -I/home/chj/src/gdb/../intl -DMI_OUT=1 -Wimplicit -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses -Wpointer-arith -Wuninitialized /home/chj/src/gdb/sparc-nat.c > In file included from /usr/include/asm/reg.h:4, > from /home/chj/src/gdb/sparc-nat.c:36: > /usr/include/asm-sparc64/reg.h:49: error: redefinition of `struct fpu' > /home/chj/src/gdb/sparc-nat.c: In function `fetch_inferior_registers': > /home/chj/src/gdb/sparc-nat.c:99: warning: cast from pointer to integer of different size > /home/chj/src/gdb/sparc-nat.c:103: warning: implicit declaration of function `memcpy' Oh. How strange, it workedforme. I'll see if I can reproduce & fix it tomorrow (assuming Daniel doesn't get to it before that). -- `It is an unfortunate coincidence that the date locarchive.h was written (in hex) matches Ritchie's birthday (in octal).' -- Roland McGrath on the libc-alpha list