Re: [commit]: Re: Enhanced language support for Modula-2

Daniel Jacobowitz
2006-05-13T16:24:13Z

On Sat, May 13, 2006 at 04:49:49PM +0100, Gaius Mulley wrote:
>
> Hi,
>
> a small note to say that I've applied the Modula-2 enhancement patches
> to the gdb cvs. Many thanks for all the guidance,

Hi Gaius,

Great to see this in. And I see you've been working on the ChangeLog
entry. But it still needs a bit of work, so here's some pointers (some
of these are from the GNU Coding Standards,
http://www.gnu.org/prep/standards/, others are only implicit there but
GDB tries to follow them carefully).

> 2006-05-09 Gaius Mulley <gaius@glam.ac.uk>

Two spaces between name and email address in the header, please.

> * gdb/m2-lang.h: added function extern prototypes for
> m2_is_long_set and get_long_set_bounds.

Path names should be relative to the directory containing the
ChangeLog, so just "m2-lang.h". Entries should start with a capital
letter and end with a period (although sentence fragments are fine).

> * gm2/m2-typeprint.c: This file has been completely
> replaced to reflect the Modula-2 syntax rather than call the
> c_print_type function.

We don't usually use explanatory sentences, just the actual changes; a
bit strange, yes...

> * gdb/dwarf2read.c: added ability to detect the language
> Modula-2 and handle SET and CHAR types.

The current version says:

* gdb/dwarf2read.c: added ability to detect the language
Modula-2
and handle SET and CHAR types.

Again about the pathname and the explanatory sentences, but also the
wrapping; what's the stray newline for?

--
Daniel Jacobowitz
CodeSourcery