Re: Enhanced language support for Modula-2

Gaius Mulley
2006-05-11T12:37:00Z

Jim Blandy <jimb@codesourcery.com> writes:

> > also enclosed is a proposed set of ChangeLog entries:
>
> Looks great!

thanks..

> Two points to fix when you commit; don't bother re-posting the patch
> for review:
>
> - There's still an overly long line in m2-valprint.c, in the
> TYPE_CODE_STRUCT case.

ok I'll fix it..

> - Similarly, there's a separate ChangeLog for the doc directory; the
> entry for your change to gdb.texinfo should go in gdb/doc/ChangeLog,
> not gdb/ChangeLog. And generally, we put section names in parens
> after the filename, as we do for functions in C files. Like so:
>
> * gdb.texinfo (M2 Types): New section.

ok.

> I see that you have a copyright assignment on file. Do you have
> commit access to GDB? If not, we'll have to get you set up with that
> first.

no I don't have commit access. Commit access would be great, thanks.

> If you do, then make a commit to gdb/MAINTAINERS, adding yourself to
> "Write After Approval", with an appropriate ChangeLog entry. Then go
> ahead and commit the rest of the patch.

sure, will do.

regards,
Gaius