From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28603 invoked by alias); 13 May 2006 18:53:25 -0000 Received: (qmail 28595 invoked by uid 22791); 13 May 2006 18:53:24 -0000 X-Spam-Check-By: sourceware.org Received: from jess.glam.ac.uk (HELO jess.glam.ac.uk) (193.63.147.97) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 13 May 2006 18:53:22 +0000 Received: from mailserv1.isd.glam.ac.uk ([192.168.244.1]) by jess.glam.ac.uk with esmtp (Exim 3.35 #1) id 1Fez5M-0006d0-00; Sat, 13 May 2006 19:43:28 +0100 Received: from floppsie ([193.63.148.84]) by MAILSERV1.isd.glam.ac.uk with Microsoft SMTPSVC(6.0.3790.1830); Sat, 13 May 2006 19:53:18 +0100 Received: from gaius by floppsie with local (Exim 4.61) (envelope-from ) id 1Fez0W-0003lh-0D; Sat, 13 May 2006 19:38:28 +0100 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com, Joel Brobecker , Eli Zaretskii , Jim Blandy Subject: Re: [commit]: Re: Enhanced language support for Modula-2 References: <20060504153726.GA2396@nevyn.them.org> <8f2776cb0605041101u7d969e0eodde33866ac4abc41@mail.gmail.com> <874q00liyr.fsf@glam.ac.uk> <874pzyrf8l.fsf@glam.ac.uk> <87mzdosqi4.fsf@glam.ac.uk> <20060512164239.GB27234@adacore.com> <87zmhlgc0y.fsf_-_@glam.ac.uk> <20060513162355.GA6564@nevyn.them.org> From: Gaius Mulley Date: Sat, 13 May 2006 18:56:00 -0000 In-Reply-To: <20060513162355.GA6564@nevyn.them.org> Message-ID: <87k68pojmk.fsf@glam.ac.uk> User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.4 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00302.txt.bz2 Daniel Jacobowitz writes: > On Sat, May 13, 2006 at 04:49:49PM +0100, Gaius Mulley wrote: > > > > Hi, > > > > a small note to say that I've applied the Modula-2 enhancement patches > > to the gdb cvs. Many thanks for all the guidance, > > Hi Gaius, > > Great to see this in. And I see you've been working on the ChangeLog > entry. But it still needs a bit of work, so here's some pointers (some > of these are from the GNU Coding Standards, > http://www.gnu.org/prep/standards/, others are only implicit there but > GDB tries to follow them carefully). Hi, many thanks for the pointers! I believe I've fixed all these now.. > Two spaces between name and email address in the header, please. done > Path names should be relative to the directory containing the > ChangeLog, so just "m2-lang.h". Entries should start with a capital > letter and end with a period (although sentence fragments are fine). done > We don't usually use explanatory sentences, just the actual changes; a > bit strange, yes... ok, removed lengthy descriptions concerning changes.. > The current version says: > > * gdb/dwarf2read.c: added ability to detect the language > Modula-2 > and handle SET and CHAR types. > > Again about the pathname and the explanatory sentences, but also the > wrapping; what's the stray newline for? and removed typo.. regards, Gaius