Re: Undefined uintptr_t with mingw

Pedro Alves
2010-12-22T12:29:09Z

On Wednesday 22 December 2010 04:00:05, Joel Brobecker wrote:
> [I changed the subject to include "gdbserver" in the subject]
>
> > diff -ur gdb-7.2orig/gdb/gdbserver/win32-low.c gdb-7.2/gdb/gdbserver/win32-low.c
> > --- gdb-7.2orig/gdb/gdbserver/win32-low.c 2010-12-21 16:27:10.000000000 +0100
> > +++ gdb-7.2/gdb/gdbserver/win32-low.c 2010-12-21 17:21:56.000000000 +0100
> > @@ -33,6 +33,7 @@
> > #include <sys/param.h>
> > #include <malloc.h>
> > #include <process.h>
> > +#include <stdint.h>

Odd that nobody reported this before. It kind of sounds like
something's different on debian's mingw...

ISTR that on mingw, stdint.h used to not be available. ISTR
that's the reason we have the stdint.h inclusion
in gdbserver/tracepoint.c guarded by HAVE_STDINT_H. Unless
someone calls me mad, this is okay, with such a guard added.

> Pedro is the current expert for gdbserver, so please wait for his
> review, but I'm thinking that we should probably do the same as GDB,
> which is include stdlib in the gdbserver equivalent of defs.h (i.e.
> server.h).

This is fine with me as well, but note that gdb/defs.h is
including stdint.h unconditionally, because it can rely that gdb/gnulib
provides one if the host doesn't have such a header, or if
it finds the system one misses features. If we go this path,
we should also wrap it in HAVE_STDINT_H.

--
Pedro Alves