From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23400 invoked by alias); 30 Mar 2012 17:51:08 -0000 Received: (qmail 23360 invoked by uid 22791); 30 Mar 2012 17:51:06 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,TW_XG,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 30 Mar 2012 17:50:49 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2UHokdj009532 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 30 Mar 2012 13:50:46 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q2UHoiRK005041 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 30 Mar 2012 13:50:45 -0400 From: Tom Tromey To: xgsa Cc: Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: set print object on should affect MI varobjs (PR mi/13393) References: <4ED92C05.9080803@yandex.ru> <4EF22A4D.80703@yandex.ru> <20111221193630.GA28985@host2.jankratochvil.net> <4EF30389.5010008@yandex.ru> <20111223200951.GA19581@host2.jankratochvil.net> <4EF5D1C5.5010902@yandex.ru> <20120102022153.GA686@host2.jankratochvil.net> <4F07177C.5080201@yandex.ru> <4F32C009.2050103@yandex.ru> <87pqdma1mo.fsf@fleche.redhat.com> <4F412637.2010405@yandex.ru> <4F660CF6.9070008@yandex.ru> <8339953anu.fsf@gnu.org> <4F66DBD0.4000903@yandex.ru> <83vcm01obe.fsf@gnu.org> <4F6CADEF.4080700@yandex.ru> Date: Fri, 30 Mar 2012 17:51:00 -0000 In-Reply-To: <4F6CADEF.4080700@yandex.ru> (xgsa@yandex.ru's message of "Fri, 23 Mar 2012 19:07:59 +0200") Message-ID: <87k422q8p7.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg01052.txt.bz2 >>>>> "Anton" == xgsa writes: Anton> Waiting for your comments! Thanks for sending this. I'm sorry about the delay, I have been quite behind on patch review :( You didn't say whether you regression-tested this. I have a few nits, but nothing serious. AFAIK it still needs a doc review. Anton> + if (real_type_found) Anton> + *real_type_found = 0; Too much indentation on the second line here. Anton> + if (real_type_found) Anton> + *real_type_found = 1; Here too. Anton> + if (real_type_found) Anton> + *real_type_found = 1; Here too. Anton> + REAL_TYPE_FOUND is used to inform whether the real type was found Anton> + (or just static type was used). The NULL may be passed if it is not Anton> + necessary. */ Two spaces after periods. Just write "NULL", not "The NULL". Anton> + if (real_type_found) Anton> + value = value_cast (var->type, value); Too much indentation. Anton> + int type_updated = update_type_if_necessary(existing, value); Space before open paren. Anton> + curr_type_str = varobj_get_type(var); Space before open paren. Anton> + if (update_type_if_necessary(v, new)) Anton> + r.type_changed = 1; Too much indentation. Tom