From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23676 invoked by alias); 27 Nov 2012 21:53:57 -0000 Received: (qmail 23667 invoked by uid 22791); 27 Nov 2012 21:53:56 -0000 X-SWARE-Spam-Status: No, hits=-6.0 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 27 Nov 2012 21:53:44 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qARLrfXN028683 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 27 Nov 2012 16:53:41 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qARLrdsB013167 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 27 Nov 2012 16:53:40 -0500 From: Tom Tromey To: markus.t.metzger@intel.com Cc: gdb-patches@sourceware.org, markus.t.metzger@gmail.com, jan.kratochvil@redhat.com, palves@redhat.com, kettenis@gnu.org Subject: Re: [patch v4 03/13] cli, btrace: add btrace cli References: <1354013351-14791-1-git-send-email-markus.t.metzger@intel.com> <1354013351-14791-4-git-send-email-markus.t.metzger@intel.com> Date: Tue, 27 Nov 2012 21:53:00 -0000 In-Reply-To: <1354013351-14791-4-git-send-email-markus.t.metzger@intel.com> (markus t. metzger's message of "Tue, 27 Nov 2012 11:49:01 +0100") Message-ID: <87k3t6btlo.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00783.txt.bz2 >>>>> "Markus" == markus t metzger writes: Markus> +/* Print the function containing the btrace list item @trace. */ Markus> +static void Markus> +do_btrace_list_function (struct btrace_block *trace) Markus> +{ Markus> + struct symbol *symbol = find_pc_function (trace->begin); Markus> + Markus> + ui_out_text (current_uiout, " in "); Markus> + if (symbol) Markus> + ui_out_field_string (current_uiout, "function", Markus> + SYMBOL_PRINT_NAME (symbol)); Markus> + else Markus> + { Markus> + struct minimal_symbol *msymbol = Markus> + lookup_minimal_symbol_by_pc (trace->begin); Markus> + Markus> + if (msymbol) Markus> + ui_out_field_string (current_uiout, "function", Markus> + SYMBOL_PRINT_NAME (msymbol)); Markus> + else Markus> + ui_out_text (current_uiout, "??"); Markus> + } Markus> + Markus> + ui_out_text (current_uiout, " ()"); I think these parens will look strange if you try it with C++ code. There, the argument types are part of the symbol name. Tom